Repository navigation
Register all tools with registerTool - #26
Merged
Merged
Conversation
Builds on the dependency fix branch. Zod raw shapes and Zod schemas now go through McpServer.registerTool instead of the deprecated server.tool() overloads, and meta-tools do too. JSON Schema inputs keep the passthrough registration. annotations.title is also sent as the tool's top-level title. Raise the zod floor to ^3.25 to match the SDK's peer range, move README examples, the demo and tests to Zod input schemas, and add real-SDK tests for argument delivery and the advertised schema, title and annotations. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BieFQPQqC2JGUck3HRPJJC
imbenrabi
force-pushed
the
claude/project-thread-dmygud
branch
from
October 10, 2026 07:20
7166c87 to
c18356e
Compare
This was referenced Oct 10, 2026
imbenrabi
marked this pull request as ready for review
October 10, 2026 09:17
Contributor
Author
Server compatibility review (Financial-Modeling-Prep-MCP-Server): GOReviewed head What I ran
Server call sites this touches
Merge notes
Generated by Claude Code |
Merged
imbenrabi
pushed a commit
that referenced
this pull request
Oct 10, 2026
The next release carries #25, #26 and #27. #27 changes STATIC mode to a server per client, so it ships as a minor version: consumers pinned to ^0.6.x keep 0.6.3 until they opt in. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Pqcus1BTWLVAJaPavwdkGX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ben · project thread
Follows #25 (merged), which bumped the SDK to
^1.32.1and keeps JSON Schema tools working.Before: Zod tools, and the meta-tools, still register through the deprecated
server.tool()overloads.annotations.titlereaches clients only inside annotations.After: every tool, meta-tools included, registers through
McpServer.registerTool. Zod raw shapes and Zod schemas go through as they are. JSON Schema inputs keep #25's passthrough object, so their behaviour is unchanged.annotations.titleis also sent as the tool's top-leveltitle(spec 2025-06-18+).How:
DynamicToolManager.registerSingleToolhas a singleregisterToolcall, andisZodInputSchema()(which also recognizes Zod v4 and full Zod schemas) picks the schema. Thezodfloor moves to^3.25to match the SDK's peer range. README examples, the demo and the tests now use Zod shapes, with a README note on what JSON Schema inputs lose. New real-SDK tests check that a Zod tool advertises its properties, title and annotations and receives its arguments, and that a JSON Schema tool receives its arguments.Verified locally: typecheck, 328/328 tests, build, and
npm audit --audit-level=critical. Financial-Modeling-Prep-MCP-Server passed typecheck and 850/850 tests against this registration code on SDK 1.32.1.🤖 Generated with Claude Code
https://claude.ai/code/session_01BieFQPQqC2JGUck3HRPJJC