fix(ci): exclude projects without previous report from bulk compare - #1288
Open
matejchalk wants to merge 1 commit into
Open
fix(ci): exclude projects without previous report from bulk compare#1288matejchalk wants to merge 1 commit into
matejchalk wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/models
@code-pushup/create-cli
@code-pushup/axe-plugin
@code-pushup/nx-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
Contributor
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 28d014d with previous commit ba41f92. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 1 group regressed, 👍 2 audits improved, 👎 1 audit regressed, 15 audits changed without impacting score🗃️ Groups
32 other groups are unchanged. 🛡️ Audits
660 other audits are unchanged. |
Contributor
Code PushUp🥳 Code PushUp report has improved – compared current commit 28d014d with previous commit ba41f92. 💼 Project
|
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 92 | 🟢 93 |
5 other categories are unchanged.
👍 1 group improved, 👍 2 audits improved
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 92 | 🟢 93 |
14 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Line coverage | 🟩 93.6 % | 🟩 94 % | |
| Code coverage | Branch coverage | 🟨 82.8 % | 🟨 83.1 % |
443 other audits are unchanged.
13 other projects are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In monorepo mode with a bulk
run-manycommand, a project which isn't configured in the base branch (typically a package newly added in the PR) is correctly skipped when collecting previous reports, but it was still included in the subsequent compare command. Since it has noreport-before.json,code-pushup comparefails for that project, which fails the wholerun-manytask and with it the CI job - so no comment is posted, even though every other project compared fine.The logs of an affected run look like this (Nx monorepo, one new package):
The previous reports are collected with an explicit projects filter (
Collecting previous reports for 14 projects), but the compare command calledrunManyCommand()without any arguments, so the handler fell back to all projects.Changes:
compareManyProjectspasses the names of the projects which actually have a previous report tocompareMany, mirroring whatcollectManyalready does for the base branch collect.report-before.json.As a side effect, the compare command is now always filtered explicitly, so for pnpm/Turborepo/Yarn ≥2 it no longer runs across the whole workspace, but only over the projects which were collected.
npm workspaces and Yarn v1 support no projects filter, so they remain affected by this bug - the same pre-existing limitation applies to the previous report collect.
🤖 Generated with Claude Code