Skip to content

fix(create-cli): pass default value to select prompt#1276

Open
hanna-skryl wants to merge 1 commit intomainfrom
create-cli-defaults
Open

fix(create-cli): pass default value to select prompt#1276
hanna-skryl wants to merge 1 commit intomainfrom
create-cli-defaults

Conversation

@hanna-skryl
Copy link
Collaborator

The select prompt in the setup wizard was not forwarding the default value from plugin bindings to @inquirer/prompts. This caused the JS packages plugin's detected package manager (e.g., pnpm) to be ignored, always defaulting to the first choice (npm) instead.

@nx-cloud
Copy link

nx-cloud bot commented Mar 23, 2026

View your CI Pipeline Execution ↗ for commit 76783be

Command Status Duration Result
nx run ci:code-pushup -- merge-diffs --files=/h... ✅ Succeeded 6s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 1m 35s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 14m 17s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 2m 11s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-23 19:45:47 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 23, 2026

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1276

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1276

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1276

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1276

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1276

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1276

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1276

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1276

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1276

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1276

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1276

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1276

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1276

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1276

commit: 76783be

@github-actions
Copy link
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 192abbd with previous commit 9a46285.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 37 🔴 34 ↓ −3.3
Updates 🟡 73 🟡 73 ↓ −0.2
Code coverage 🟢 92 🟢 92 ↑ +0.1
Bug prevention 🟡 75 🟡 75 ↓ −0.1
Axe Accessibility 🟡 88 🟡 88 ↓ −0.1
Code style 🟢 100 🟢 100
Security 🔴 0 🔴 0
Type Safety 🟡 67 🟡 67
Miscellaneous 🟡 67 🟡 67
Documentation 🟡 52 🟡 52
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟢 92 🟢 92
👍 1 group improved, 👎 2 groups regressed, 👍 2 audits improved, 👎 5 audits regressed, 14 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 37 🔴 34 ↓ −3.3
JS packages npm outdated dependencies 🟡 73 🟡 73 ↓ −0.2
Code coverage Code coverage metrics 🟢 92 🟢 92 ↑ +0.1

31 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟨 5.7 s 🟥 6.5 s ↑ +13.9 %
Lighthouse First Contentful Paint 🟨 3.0 s 🟥 3.3 s ↑ +9.9 %
Lighthouse Total Blocking Time 🟥 2,030 ms 🟥 2,770 ms ↑ +36.5 %
JS packages Outdated npm dev dependencies. 🟨 62 outdated package versions (33 major, 23 minor, 6 patch) 🟨 62 outdated package versions (34 major, 22 minor, 6 patch)  +0 %
Lighthouse Time to Interactive 🟥 14.2 s 🟥 14.6 s ↑ +3 %
Code coverage Branch coverage 🟨 89.2 % 🟨 89.2 % ↑ +0.1 %
Code coverage Line coverage 🟩 92.2 % 🟩 92.2 % ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,449 KiB 🟩 Total size was 2,456 KiB ↑ +0.3 %
Lighthouse Minimizes main-thread work 🟥 11.3 s 🟥 12.8 s ↑ +13 %
Lighthouse JavaScript execution time 🟥 2.9 s 🟥 4.0 s ↑ +36.9 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +3 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 270 KiB 🟥 Potential savings of 270 KiB ↓ −29.6 %
Lighthouse Uses efficient cache policy on static assets 🟨 31 resources found 🟨 31 resources found ↑ +0.1 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 107 KiB 🟥 Potential savings of 112 KiB ↓ −31.9 %
Lighthouse Initial server response time was short 🟩 Root document took 390 ms 🟩 Root document took 520 ms ↑ +33.6 %
Lighthouse Server Backend Latencies 🟩 850 ms 🟩 730 ms ↓ −13.8 %
Lighthouse Largest Contentful Paint 🟥 13.4 s 🟥 13.3 s ↓ −0.7 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 111 KiB 🟥 Potential savings of 111 KiB ↑ +4.3 %
Lighthouse Network Round Trip Times 🟩 10 ms 🟩 30 ms ↑ +154.4 %
Lighthouse Max Potential First Input Delay 🟥 1,280 ms 🟥 1,270 ms ↓ −0.5 %
Lighthouse Cumulative Layout Shift 🟩 0 🟩 0 ↓ −100 %

657 other audits are unchanged.

@github-actions
Copy link
Contributor

Code PushUp

🥳 Code PushUp report has improved – compared current commit 192abbd with previous commit 9a46285.

💼 Project create-cli

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 90 🟢 90 ↑ +0.1

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 90 🟢 90 ↑ +0.1

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Line coverage 🟩 91.2 % 🟩 91.6 % ↑ +0.4 %
Code coverage Branch coverage 🟩 90.8 % 🟩 91.1 % ↑ +0.3 %

441 other audits are unchanged.

💼 Project plugin-coverage

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🟡 68 🟡 68 ↑ +0.1

5 other categories are unchanged.

👍 1 group improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDocs coverage Documentation coverage 🟡 68 🟡 68 ↑ +0.1

14 other groups are unchanged.

🛡️ Audits

All of 444 audits are unchanged.

💼 Project utils

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🟡 61 🟡 61 ↑ +0.1

5 other categories are unchanged.

👍 1 group improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDocs coverage Documentation coverage 🟡 61 🟡 61 ↑ +0.1

14 other groups are unchanged.

🛡️ Audits

All of 444 audits are unchanged.


11 other projects are unchanged.

@hanna-skryl hanna-skryl marked this pull request as ready for review March 23, 2026 20:40
@hanna-skryl hanna-skryl requested a review from matejchalk March 23, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant