Skip to content

Conversation

@BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Nov 9, 2025

Remove folders from .nxignore and rename files to not get detected by Nx

Followup PR:

  • one last folder is remaining under packages/plugin-eslint/mocks/fixtures/nx-monorepo

closes #1102

@nx-cloud
Copy link

nx-cloud bot commented Nov 9, 2025

View your CI Pipeline Execution ↗ for commit 6dff5a7

Command Status Duration Result
nx code-pushup --nx-bail -- compare ✅ Succeeded 48s View ↗
nx code-pushup --nx-bail -- ✅ Succeeded 55s View ↗
nx code-pushup --nx-bail -- print-config --outp... ✅ Succeeded 3m 44s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-10 14:42:08 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 9, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1142

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1142

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1142

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1142

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1142

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1142

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1142

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1142

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1142

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1142

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1142

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1142

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1142

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1142

commit: 6dff5a7

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 0d82b87 with previous commit 9876d94.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 34 🔴 42 ↑ +7.5
Code coverage 🟡 88 🟡 88 ↑ +0.1
Documentation 🔴 36 🔴 36 ↑ +0.1
Security 🟡 56 🟡 56
Updates 🟡 73 🟡 73
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 3 groups improved, 👍 8 audits improved, 👎 1 audit regressed, 12 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 34 🔴 42 ↑ +7.5
Code coverage Code coverage metrics 🟡 88 🟡 88 ↑ +0.1
JSDoc coverage Documentation coverage 🔴 36 🔴 36 ↑ +0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟥 Root document took 690 ms 🟩 Root document took 570 ms ↓ −17.8 %
Lighthouse Total Blocking Time 🟥 2,060 ms 🟥 980 ms ↓ −52.5 %
Lighthouse Speed Index 🟥 7.1 s 🟥 6.6 s ↓ −7.2 %
Lighthouse First Contentful Paint 🟥 3.4 s 🟥 3.1 s ↓ −6.4 %
Lighthouse Time to Interactive 🟥 13.3 s 🟥 12.9 s ↓ −3 %
Code coverage Line coverage 🟨 84.5 % 🟨 84.6 % ↑ +0.2 %
Code coverage Function coverage 🟨 89.4 % 🟨 89.5 % ↑ +0.1 %
Code coverage Branch coverage 🟨 86.5 % 🟨 86.5 % ↓ −0.1 %
JSDoc coverage Functions coverage 🟥 524 undocumented functions 🟥 523 undocumented functions ↓ −0.2 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,047 KiB 🟩 Total size was 2,061 KiB ↑ +0.7 %
Lighthouse Minimizes main-thread work 🟥 12.7 s 🟥 8.9 s ↓ −29.5 %
Lighthouse JavaScript execution time 🟥 5.3 s 🟥 3.5 s ↓ −33.2 %
Lighthouse Server Backend Latencies 🟩 120 ms 🟩 910 ms ↑ +637.7 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −3 %
Lighthouse Largest Contentful Paint 🟥 10.9 s 🟥 11.2 s ↑ +3.2 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↑ +0.1 %
Lighthouse Max Potential First Input Delay 🟥 1,140 ms 🟥 910 ms ↓ −20.6 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 180 KiB 🟥 Potential savings of 181 KiB ↑ +26.9 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 94 KiB 🟥 Potential savings of 94 KiB ↑ +40.4 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 105 KiB 🟥 Potential savings of 101 KiB ↑ +58.1 %
Lighthouse Network Round Trip Times 🟩 60 ms 🟩 50 ms ↓ −13.5 %

589 other audits are unchanged.

@BioPhoton BioPhoton requested a review from hanna-skryl November 9, 2025 22:58
Copy link
Collaborator

@matejchalk matejchalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried replicating the cache bug in plugin-eslint as described in #1102, and it now works as I would expect. 🎉

I left some suggestions for improving the setup tests.

Don't forget to update the PR description, now that you've covered plugin-eslint, I believe this PR can close the issue without a follow-up PR (closes #1102).

Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton BioPhoton merged commit 4a982a5 into main Nov 10, 2025
20 of 21 checks passed
@BioPhoton BioPhoton deleted the test/e2e/refactor-nx-ignore branch November 10, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalidate test cache when fixtures change

3 participants