-
Notifications
You must be signed in to change notification settings - Fork 16
refactor: fix cache invalidation for tests in monorepo setups #1142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
View your CI Pipeline Execution ↗ for commit 6dff5a7
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/coverage-plugin
@code-pushup/nx-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
@code-pushup/models-transformers
commit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 0d82b87 with previous commit 9876d94. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 3 groups improved, 👍 8 audits improved, 👎 1 audit regressed, 12 audits changed without impacting score🗃️ Groups
18 other groups are unchanged. 🛡️ Audits
589 other audits are unchanged. |
matejchalk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried replicating the cache bug in plugin-eslint as described in #1102, and it now works as I would expect. 🎉
I left some suggestions for improving the setup tests.
Don't forget to update the PR description, now that you've covered plugin-eslint, I believe this PR can close the issue without a follow-up PR (closes #1102).
testing/test-utils/src/lib/utils/test-folder-setup.unit.test.ts
Outdated
Show resolved
Hide resolved
testing/test-utils/src/lib/utils/test-folder-setup.unit.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Remove folders from
.nxignoreand rename files to not get detected by NxFollowup PR:one last folder is remaining underpackages/plugin-eslint/mocks/fixtures/nx-monorepocloses #1102