feat: adds new methods for MediaItemsController.java for lesson 26 #679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonydmays
requested changes
Dec 5, 2024
| Set<MediaItem> item = library.search(SearchCriteria.builder().id(id.toString()).build()); | ||
| if (item.isEmpty()) { | ||
| return ResponseEntity.notFound().build(); | ||
| } else if (!test1.contains(item.iterator().next()) || item.iterator().next() == null) { |
Contributor
There was a problem hiding this comment.
Why are you doing this? Doesn't seem necessary at all. My guess is removing this code (and test1) above won't change your results at all.
| public ResponseEntity<?> postItems(@RequestBody CreateMediaItemRequest requestBody) { | ||
| List<String> errorsList = new ArrayList<>(); | ||
| MediaItemRequest request = requestBody.getItem(); | ||
| if (requestBody.getItem() == null) { |
Contributor
There was a problem hiding this comment.
Won't need any of this validation code if you just use the @Valid attribute on the requestBody argument.
| Set<MediaItem> items = library.search(SearchCriteria.builder().id(id.toString()).build()); | ||
| Optional<MediaItem> matchedItem = | ||
| items.stream().filter(item -> item.getId().equals(id)).findFirst(); | ||
| System.out.println("items"); |
Contributor
There was a problem hiding this comment.
Remove debugging statements.
| public ResponseEntity<GetMediaItemsResponse> getItemById() { | ||
| Set<MediaItem> items = library.search(SearchCriteria.builder().build()); | ||
| if (items.isEmpty()) { | ||
| ResponseEntity.noContent(); |
Contributor
There was a problem hiding this comment.
Nope, should return GetMediaItmesResponse with an empty list of items. Anything else would be unexpected and unusual.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.