Open
Conversation
Fixing bug with different HOST_DIRECTORY
Member
Author
|
CircleCI tests are passing. Doubts to check: Having first the directory creation: # Create if necessary
os.makedirs(path, exist_ok=True)And then the path concatenation: path = os.path.join(HOST_DIRECTORY, path)
return pathIt means that the path returned by the function is not the path passed to makedirs. It looks like we have then no guarantee that the directory exists. I may need to check it out more in depth I feel like this could introduce a bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR from @jbehley: #2311
Description
This is again a pull request with the (only) necessary changes to allow a different HOST_DIRECTORY`.
In our setup, we want to have a different HOST_DIRECTORY than
/codabench. Note that the problem does not occur if the directory on host and inside the container are/codabench.Let's say we have
HOST_DIRECTORY = /home/codabench/and the desired directory is/codabench/data/temp/. Thenmakedirswill try to create/home/codabench/data/tempinside the container, which leads to an error.Btw, we run the worker with podman and with the change it runs now since quite some time with over 350 submissions.
Checklist