chore(deps): Bump errata-ai/vale-action from 2.1.0 to 2.1.2#358
chore(deps): Bump errata-ai/vale-action from 2.1.0 to 2.1.2#358dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [errata-ai/vale-action](https://github.com/errata-ai/vale-action) from 2.1.0 to 2.1.2. - [Release notes](https://github.com/errata-ai/vale-action/releases) - [Commits](vale-cli/vale-action@38bf078...85f9f7f) --- updated-dependencies: - dependency-name: errata-ai/vale-action dependency-version: 2.1.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
The pull request successfully updates the errata-ai/vale-action version, and Codacy results indicate the changes are up to standards. However, there is a significant functional gap: the upgrade path includes v2.1.1, which removed bundled support for non-Markdown formats. If this repository uses formats like AsciiDoc or reStructuredText, the Vale step will likely fail or produce incomplete results because the necessary format-specific dependencies are no longer included in the action and have not been added to the workflow in this PR.
About this PR
- The v2.1.1 release notes indicate that the action no longer includes format-specific dependencies (e.g., Asciidoctor, Docutils). This PR updates the version but does not provide the manual installation steps now required for these formats. This change may break linting for non-Markdown files.
Test suggestions
- Vale action version is correctly updated in the workflow file
- Verify if manual installation of format-specific dependencies (e.g., Asciidoctor, Docutils) is required per v2.1.1 release notes
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify if manual installation of format-specific dependencies (e.g., Asciidoctor, Docutils) is required per v2.1.1 release notes
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
|
|
||
| - name: Vale | ||
| uses: errata-ai/vale-action@38bf078c328061f59879b347ca344a718a736018 # v2.1.0 | ||
| uses: errata-ai/vale-action@85f9f7f2c5f449ac0ae5b66662961bae3f77ca6a # v2.1.2 |
There was a problem hiding this comment.
🟡 MEDIUM RISK
Starting with v2.1.1, the action no longer includes format-specific dependencies (like Asciidoctor for .adoc or Docutils for .rst). If this repository uses these formats, you must add steps to install them in the workflow before the Vale step, otherwise linting for those files will fail.
Bumps errata-ai/vale-action from 2.1.0 to 2.1.2.
Release notes
Sourced from errata-ai/vale-action's releases.
Commits
85f9f7fFix Node 24 action compatibility975d503update deps73d2cd4update to node240135b9fUpdate repository link and organization name13286adupdate READMEdcded78Add.well-knownd568351Merge pull request #149 from StaticRocket/reviewdogd377866feat: allow use of local version of vale2690bc9Add reStructuredText example18ca075FormattingDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)