Bump ReverseMarkdown from 3.19.0 to 6.0.0#138
Conversation
--- updated-dependencies: - dependency-name: ReverseMarkdown dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades ReverseMarkdown from version 3.19.0 to 6.0.0. While the change is small in terms of lines of code, the underlying dependency has undergone a ground-up rewrite, transitioning from HtmlAgilityPack to AngleSharp and introducing a new Markdown DOM pipeline.
Although Codacy marks the PR as up to standards, the upgrade introduces significant risk because no corresponding tests or configuration updates have been provided to verify that the documentation generation remains consistent. Specifically, breaking changes in intervening versions (like the renaming of configuration properties) may lead to runtime issues or regressions in the generated output that are not captured by the current test suite.
About this PR
- The upgrade from ReverseMarkdown 3.19.0 to 6.0.0 involves a complete rewrite of the conversion engine and a major configuration overhaul. This PR lacks corresponding code changes or updated tests to verify that the library's consumer (DocsGenerator) still functions correctly. There is a high risk of breaking changes, such as the renaming of
SuppressNewlinestoSuppressDivNewlinesin v4.3.0, which could affect documentation generation if those features are utilized.
Test suggestions
- Verify that the Markdown output generated by DocsGenerator remains consistent or improved following the transition to the new AngleSharp-based engine.
- Ensure that any existing configuration options (e.g., SuppressNewlines which was renamed in v4.3.0) used by DocsGenerator are updated or confirmed to be compatible with the v6.0.0 configuration overhaul.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that the Markdown output generated by DocsGenerator remains consistent or improved following the transition to the new AngleSharp-based engine.
2. Ensure that any existing configuration options (e.g., SuppressNewlines which was renamed in v4.3.0) used by DocsGenerator are updated or confirmed to be compatible with the v6.0.0 configuration overhaul.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
|
Superseded by #139. |
Updated ReverseMarkdown from 3.19.0 to 6.0.0.
Release notes
Sourced from ReverseMarkdown's releases.
6.0.0
v6 is a ground-up rewrite of the conversion engine. HTML is parsed with AngleSharp's HTML5-compliant parser into an intermediate Markdown DOM, which is rendered through per-flavor writers. The result is more correct, faster, leaner, and extensible - while keeping the public API source-compatible with v5.
Engine
Output flavors
Seven output flavors, selected via the single canonical Flavor enum (MarkdownFlavor):
Spec compliance
Extensibility
HTML pre-filtering (new)
Configuration overhaul
<pre>-as-HTML, line-start escaping, configurable line endings, bullet character, and default code-block language.Framework support
Performance
... (truncated)
5.5.0
What's Changed
Full Changelog: mysticmind/reversemarkdown-net@5.4.0...5.5.0
5.4.0
✨ New features
🐛 Bug fixes
[[UnmanagedCallersOnly]](…)previously became[\[UnmanagedCallersOnly\]](…). Brackets inside backtick code spans are now left untouched; brackets outside code spans are still escaped.🔧 Maintenance
Full Changelog: mysticmind/reversemarkdown-net@5.3.0...5.4.0
5.3.0
What's Changed
Full Changelog: mysticmind/reversemarkdown-net@5.2.1...5.3.0
5.2.1
What's Changed
Full Changelog: mysticmind/reversemarkdown-net@5.2.0...5.2.1
5.2.0
What's Changed
<pre>content as HTML by @mysticmind in Add option to convert <pre> content as HTML mysticmind/reversemarkdown-net#422Full Changelog: mysticmind/reversemarkdown-net@5.1.0...5.2.0
5.1.0
What's Changed
New Contributors
Full Changelog: mysticmind/reversemarkdown-net@5.0.0...5.1.0
5.0.0
What's Changed
<p>Tags by @ssperling-wmp in Fixing #408 Exponential Time Complexity Bug Causing Hangs with Nested <p> Tags mysticmind/reversemarkdown-net#409Milestone 5.0.0
New Contributors
Full Changelog: mysticmind/reversemarkdown-net@4.7.0...5.0.0
4.7.1
Fix Exponential Time Complexity Bug Causing Hangs with Nested
<p>Tags GH-408 by @ssperling-wmp (cherry-picked and merged from master)Full Changelog: mysticmind/reversemarkdown-net@4.7.0...4.7.1
4.7.0
What's Changed
New Contributors
Full Changelog: mysticmind/reversemarkdown-net@4.6.0...4.7.0
4.6.0
What's Changed
New Contributors
Full Changelog: mysticmind/reversemarkdown-net@4.5.0...4.6.0
4.5.0
Full Changelog: mysticmind/reversemarkdown-net@4.4.0...4.5.0
4.4.0
Full Changelog: mysticmind/reversemarkdown-net@4.3.0...4.4.0
4.3.0
SuppressNewlinestoSuppressDivNewlines. Note that 4.2.0 was published with incorrect name so unlisted it rather than bumping up the major version due to this change.Full Changelog: mysticmind/reversemarkdown-net@4.2.0...4.3.0
4.2.0
What's Changed
Note: NuGet version unlisted due to incorrect config name, see 4.3.0 for details.
New Contributors
Full Changelog: mysticmind/reversemarkdown-net@4.1.0...4.2.0
4.1.0
Whats Changed
s,delandstrike#356Full Changelog: mysticmind/reversemarkdown-net@4.0.0...4.1.0
4.0.0
What's Changed
<sup>tag conversion by @francescolf in Add support for <sup> tag conversion mysticmind/reversemarkdown-net#358New Contributors
Full Changelog: mysticmind/reversemarkdown-net@3.25.0...4.0.0
3.25.0
Full Changelog: mysticmind/reversemarkdown-net@3.24.0...3.25.0
3.24.0
What's Changed
Full Changelog: mysticmind/reversemarkdown-net@3.23.1...3.24.0
Milestone: https://github.com/mysticmind/reversemarkdown-net/milestone/24?closed=1
3.23.1
Full Changelog: mysticmind/reversemarkdown-net@3.23.0...3.23.1
3.23.0
Full Changelog: mysticmind/reversemarkdown-net@3.22.0...3.23.0
3.22.0
Full Changelog: mysticmind/reversemarkdown-net@3.21.0...3.22.0
3.21.0
Full Changelog: mysticmind/reversemarkdown-net@3.20.0...3.21.0
3.20.0
Commits viewable in compare view.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)