Remove Sonatype publishing - #110
Open
ricardobernardino2024 wants to merge 1 commit into
Open
ricardobernardino2024 wants to merge 1 commit into
ricardobernardino2024 wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
No merge-blocking code, security, or quality issues were identified. Codacy is up to standards. However, none of the required publishing validation scenarios are covered, including confirmation that artifacts reach the private repository and that Sonatype/GPG operations are no longer invoked.
About this PR
- The publish workflow and repository destination have not been validated by tests or end-to-end evidence. Add automated coverage or CI validation for the publishing command, settings, destination, and removal of GPG/Sonatype steps.
Test suggestions
- Verify the CircleCI publish job runs successfully with
sbt "clean;+publish". - Verify artifacts are published to the configured private repository and not Sonatype/Maven Central.
- Verify the build uses
privateMvnPublishfor publishing settings. - Verify the publish command no longer invokes GPG retrieval, signed publishing, or Sonatype Central release.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify the CircleCI publish job runs successfully with `sbt "clean;+publish"`.
2. Verify artifacts are published to the configured private repository and not Sonatype/Maven Central.
3. Verify the build uses `privateMvnPublish` for publishing settings.
4. Verify the publish command no longer invokes GPG retrieval, signed publishing, or Sonatype Central release.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publish(or the project's cross-build equivalent)publicMvnPublishtoprivateMvnPublishTest plan
publishCircleCI job runs successfully on this branch🤖 Generated with Claude Code