Skip to content

Remove Sonatype publishing - #110

Open
ricardobernardino2024 wants to merge 1 commit into
masterfrom
remove-sonatype-publishing
Open

ricardobernardino2024 wants to merge 1 commit into
masterfrom
remove-sonatype-publishing

Conversation

@ricardobernardino2024

Copy link
Copy Markdown

Summary

  • Drop the GPG key retrieval, signed-publish, and Sonatype Central release steps from the CircleCI publish job
  • Switch the SBT publish task to a plain publish (or the project's cross-build equivalent)
  • Switch the SBT publish settings from publicMvnPublish to privateMvnPublish

Test plan

  • Confirm the publish CircleCI job runs successfully on this branch
  • Confirm artifacts land in the expected (private) repository instead of Sonatype/Maven Central

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

No merge-blocking code, security, or quality issues were identified. Codacy is up to standards. However, none of the required publishing validation scenarios are covered, including confirmation that artifacts reach the private repository and that Sonatype/GPG operations are no longer invoked.

About this PR

  • The publish workflow and repository destination have not been validated by tests or end-to-end evidence. Add automated coverage or CI validation for the publishing command, settings, destination, and removal of GPG/Sonatype steps.

Test suggestions

  • Verify the CircleCI publish job runs successfully with sbt "clean;+publish".
  • Verify artifacts are published to the configured private repository and not Sonatype/Maven Central.
  • Verify the build uses privateMvnPublish for publishing settings.
  • Verify the publish command no longer invokes GPG retrieval, signed publishing, or Sonatype Central release.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify the CircleCI publish job runs successfully with `sbt "clean;+publish"`.
2. Verify artifacts are published to the configured private repository and not Sonatype/Maven Central.
3. Verify the build uses `privateMvnPublish` for publishing settings.
4. Verify the publish command no longer invokes GPG retrieval, signed publishing, or Sonatype Central release.

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant