Repository navigation
review: test fix, style, cuts, docs - #313
Merged
Merged
Conversation
NOTIFY channels are database-wide, so a parallel package writing the same cell name could fire the watch inside its quiet window.
….Context in a test body, one-line dir package doc
- config: the egress fingerprint sorts the secrets as loaded; validation already rejects a value, so the field-by-field copy changed nothing - metastore: Listen holds its one-connection loop inline and passes the config straight to ConnectConfig, which copies it itself - server: list checkpoints and put pools answer through writeResult - store/dir: hashExport drops the chunk count (one task per chunk already bounds the workers); sweepGenerations has one ReadDir loop with a keep set - tenants/pg: an entry is present when it holds a record - store/dir test: the Metas benchmark seeds through mustPublish
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review round on main b778c66, covering the 21 files that #310, #311 and #312 changed. Every other file is unchanged since the last round and keeps its ledger verdict.
What changed
TestWatchFiresOnConnectAndOnItsCellsWritesinside its quiet window. The test now listens on a cell named after its own schema.errors.Is(err, fs.ErrNotExist)replacesos.IsNotExistin store/dir.%wwraps the key error inManager.validate.t.Context().value, so the field-by-field copy produced the same digest bytes.metastore.Listenholds its one-connection loop inline, so the callback types are written once. It passes the config straight toConnectConfig, which copies it.handleListCheckpointsandhandlePutPoolsanswer throughwriteResult.hashExportdrops the chunk count, since one errgroup task per chunk already bounds the workers.sweepGenerationshas oneReadDirloop with a keep set.presentflag was alwaysrec != nil).mustPublish.meta_storeneeds the database at boot, because both shared sets open it there.pools.jsonis served when the row read fails after the connection succeeds, and kept if the node leaves the cell.Net: prod +47/−83 (−36), test +13/−17 (−4). Comment lines +2/−4. No hot path is touched: the cuts are in config load, the pool-set listener, two handlers, and the store's cold sweep and export paths.
Owner calls (not applied)
meta_store, PostgreSQL must be reachable at boot (tenants/pg and poolset/pg both runensureTableinOpen). Apools.jsonfallback for "database down at boot" would need both stores to open lazily. The docs now state the real behavior.adoptPoolsreusingdesiredPools. About −5 prod lines and one validation path. A hand-editedpools.jsoncarrying config-owned fields or a duplicate key would then refuse to boot instead of being tolerated, and the error text changes.Evidence
GOWORK=off make go-lint: 10 ×0 issues.asl -forwarder=false ./...: clean on darwin and linux for sandboxd, sdk/go, e2e, protocol/wire and mcp. The advisory forwarder findings (skipIdle,refillGated,benignSweepErr) are already KEPT in the ledger.go test -race -count=1 ./...(sandboxd) passes:SANDBOXD_TEST_PG_URLset;golang:1.27.1linux/arm64 container with PostgreSQL (as non-root, plus.andmeshas root because of a read-only module cache).