Skip to content

Org upkeep (.github#1): lint baseline, Go 1.27.1, tool pins, core v0.1.5, JSON logs off a terminal - #19

Merged
CMGS merged 6 commits into
mainfrom
upkeep/github-1
Sep 24, 2026
Merged

CMGS merged 6 commits into
mainfrom
upkeep/github-1

Conversation

@CMGS

@CMGS CMGS commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Implements the per-repo part of cocoonstack/.github#1: revive default rules, nolintlint, Go 1.27.1, the pinned tool versions, projecteru2/core v0.1.5 and JSON log records when stderr is not a terminal (only the sections that apply here).

Commits

  • 735921e lint: enable revive default rules
  • 96eb380 lint: enable nolintlint, drop unused directives
  • b24b174 build: go 1.27.1
  • 93de917 build: goreleaser v2.18.2
  • 1091179 log: JSON records when stderr is not a terminal
  • 291a3a1 deps: projecteru2/core v0.1.5

Notes

  • The empty-block drain loop in agent/agent_test.go is now an explicit loop that returns on the first encode error.
  • core v0.1.5 moves only indirect lines (sentry-go, genproto/rpc).

JSON logs off a terminal

cocoon-agent bogus: stderr to a file gives {"level":"error","func":"cmd.run",...}; under script -q the console line has ANSI colour codes.

Gates

Run with GOWORK=off against the pinned golangci-lint v2.13.2 (built with go1.27.1):

fmt-check PASS
lint PASS
asl-linux PASS
asl-darwin PASS
asl-windows PASS
test PASS
build PASS

gofumpt v0.12.0 / goimports v0.50.0 are held until the next golangci-lint release vendors them (see the issue).

Rewrite the empty-block drain loop as an explicit encode-until-error loop.
Drop the errcheck directive on a deferred Close in a _test.go file, where
errcheck is already excluded.
core v0.1.5 also lifts getsentry/sentry-go to v0.49.0 and the genproto/rpc
pseudo-version; both stay indirect.
@CMGS
CMGS merged commit b51b197 into main Sep 24, 2026
2 checks passed
@CMGS
CMGS deleted the upkeep/github-1 branch September 24, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant