Conversation
taroface
requested review from
Jeremyyang920,
crash-overdrive,
ryanluu12345 and
tuansydau
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
Files changed: |
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
Jeremyyang920
left a comment
Jeremyyang920
left a comment
There was a problem hiding this comment.
lgtm. Just the singular comment
jhlodin
left a comment
jhlodin
left a comment
There was a problem hiding this comment.
LGTM, one nit & one suggestion
| - Added support for Oracle's Large Object (`CLOB`, `NCLOB`, `BLOB`, `LONG`) and binary (`RAW`, `LONG RAW`) datatypes when failing back from CockroachDB to Oracle, within currently supported size limits. | ||
| - Added support for failback replication with mismatched time types between CockroachDB and Oracle (for example, `TIMESTAMPTZ` to `TIMESTAMP`/`DATE`), and support for Oracle timestamp replication regardless of NLS format settings. | ||
| - Replication from MySQL sources now supports core sequencer and the `--target-apply-queue-size` flag with core sequencer metrics, leading to improved throughput for MySQL-to-CockroachDB migrations. | ||
| - Added support for metrics snapshotting to aid in support investigations. This feature is off by default but can be configured to capture metrics dumps. Included `export-metrics-snapshots.sh` and `import-metrics-snapshots.sh` helper scripts to package metrics snapshots. |
There was a problem hiding this comment.
Should link to relevant docs. Seems like /molt/molt-replicator#metrics would be the right location
There was a problem hiding this comment.
Agreed, now that we have the metrics snapshotting section (just so customers can explore the feature)
There was a problem hiding this comment.
For maintainability, we stopped linking release notes to docs a year or two ago. I'm inclined to keep that consistent unless there is a strong reason MOLT and CRDB release notes should differ on this.
There was a problem hiding this comment.
ACK. If it's precedent then no need to break on my count. As long as we don't end up with features only documented in release notes, but that's not the case here.
ryanluu12345
left a comment
ryanluu12345
left a comment
There was a problem hiding this comment.
LGTM other than references to metrics snapshotting section.
Co-authored-by: Joe Lodin <joe.lodin@cockroachlabs.com>
4 participants
DOC-16218
DOC-16219