db-console: convert login components to functional components#164534
Draft
jasonlmfong wants to merge 1 commit intocockroachdb:masterfrom
Draft
db-console: convert login components to functional components#164534jasonlmfong wants to merge 1 commit intocockroachdb:masterfrom
jasonlmfong wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Convert the following class components to functional style:
- PasswordLoginForm:
1. class state → useState for username and password
2. handleUpdate methods simplified to direct setter references
- LoginPage:
1. componentDidUpdate redirect → useEffect with loggedInUser dep
2. renderError kept as inner function
- RequireLogin:
1. componentDidMount + componentDidUpdate → single useEffect
2. connect + withRouter → useSelector + useHistory + useLocation
Epic: CRDB-58145
Release note: None
Contributor
|
Merging to
|
Member
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert the following class components to functional style:
Epic: CRDB-58145
Release note: None