-
Notifications
You must be signed in to change notification settings - Fork 1
Add SSA conditions helpers in internal/utils #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fwiesel
wants to merge
1
commit into
main
Choose a base branch
from
ssa-conditions-helpers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+421
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,136 @@ | ||
| /* | ||
| SPDX-FileCopyrightText: Copyright 2024 SAP SE or an SAP affiliate company and cobaltcore-dev contributors | ||
| SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package utils | ||
|
|
||
| import ( | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| k8sacmetav1 "k8s.io/client-go/applyconfigurations/meta/v1" | ||
| ) | ||
|
|
||
| // ConditionFromStatus converts a single metav1.Condition into a | ||
| // *k8sacmetav1.ConditionApplyConfiguration, preserving all fields verbatim | ||
| // (including LastTransitionTime and ObservedGeneration). | ||
| // | ||
| // Controllers must seed their apply-config payload with the conditions they | ||
| // own before mutating them. With +listType=map / +listMapKey=type on the CRD, | ||
| // SSA merges conditions by the "type" key: conditions owned by other field | ||
| // managers are left untouched, and conditions previously written by this | ||
| // field manager that are absent from the payload are pruned. Therefore each | ||
| // controller should include all conditions it has previously set — and only | ||
| // those — in every Apply call. | ||
| func ConditionFromStatus(c metav1.Condition) *k8sacmetav1.ConditionApplyConfiguration { | ||
| return &k8sacmetav1.ConditionApplyConfiguration{ | ||
| Type: &c.Type, | ||
| Status: &c.Status, | ||
| Reason: &c.Reason, | ||
| Message: &c.Message, | ||
| LastTransitionTime: &c.LastTransitionTime, | ||
| ObservedGeneration: &c.ObservedGeneration, | ||
| } | ||
| } | ||
|
|
||
| // SetApplyConfigurationStatusCondition sets the corresponding condition in | ||
| // conditions to newCondition and returns true if the conditions are changed by | ||
| // this call. It mirrors the behaviour of k8s.io/apimachinery/pkg/api/meta.SetStatusCondition: | ||
| // | ||
| // 1. If a condition of the specified type does not exist, newCondition is | ||
| // appended. LastTransitionTime is set to now if not provided. | ||
| // 2. If a condition of the specified type already exists, all fields are | ||
| // updated. LastTransitionTime is updated to now (or the provided value) | ||
| // only when Status changes; otherwise the existing LastTransitionTime is | ||
| // preserved. | ||
| func SetApplyConfigurationStatusCondition(conditions *[]k8sacmetav1.ConditionApplyConfiguration, newCondition k8sacmetav1.ConditionApplyConfiguration) (changed bool) { | ||
| if conditions == nil { | ||
| return false | ||
| } | ||
| if newCondition.Type == nil || *newCondition.Type == "" { | ||
| return false | ||
| } | ||
|
|
||
| // Find existing entry by type | ||
| var existing *k8sacmetav1.ConditionApplyConfiguration | ||
| for i := range *conditions { | ||
| if (*conditions)[i].Type != nil && *(*conditions)[i].Type == *newCondition.Type { | ||
| existing = &(*conditions)[i] | ||
| break | ||
| } | ||
| } | ||
|
|
||
| if existing == nil { | ||
| // New condition: set LastTransitionTime if not provided | ||
| if newCondition.LastTransitionTime == nil { | ||
| now := metav1.Now() | ||
| newCondition.LastTransitionTime = &now | ||
| } | ||
| *conditions = append(*conditions, newCondition) | ||
| return true | ||
| } | ||
|
|
||
| // Existing condition: update fields, handle LastTransitionTime | ||
| statusChanged := (existing.Status == nil) != (newCondition.Status == nil) || | ||
| (existing.Status != nil && *existing.Status != *newCondition.Status) | ||
|
|
||
| if statusChanged { | ||
| existing.Status = newCondition.Status | ||
| if newCondition.LastTransitionTime != nil { | ||
| existing.LastTransitionTime = newCondition.LastTransitionTime | ||
| } else { | ||
| now := metav1.Now() | ||
| existing.LastTransitionTime = &now | ||
| } | ||
| changed = true | ||
| } | ||
| // When status is unchanged, LastTransitionTime is intentionally preserved. | ||
|
|
||
| if strChanged(existing.Reason, newCondition.Reason) { | ||
| existing.Reason = newCondition.Reason | ||
| changed = true | ||
| } | ||
| if strChanged(existing.Message, newCondition.Message) { | ||
| existing.Message = newCondition.Message | ||
| changed = true | ||
| } | ||
| if int64Changed(existing.ObservedGeneration, newCondition.ObservedGeneration) { | ||
| existing.ObservedGeneration = newCondition.ObservedGeneration | ||
| changed = true | ||
| } | ||
|
|
||
| return changed | ||
| } | ||
|
|
||
| // strChanged reports whether the pointer value of b differs from a. | ||
| func strChanged(a, b *string) bool { | ||
| if a == nil && b == nil { | ||
| return false | ||
| } | ||
| if a == nil || b == nil { | ||
| return true | ||
| } | ||
| return *a != *b | ||
| } | ||
|
|
||
| // int64Changed reports whether the pointer value of b differs from a. | ||
| func int64Changed(a, b *int64) bool { | ||
| if a == nil && b == nil { | ||
| return false | ||
| } | ||
| if a == nil || b == nil { | ||
| return true | ||
| } | ||
| return *a != *b | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't this use
strChanged? If I read it correctlyConditionStatusis a type of string.