Skip to content

Docs Update #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Docs Update #12

wants to merge 2 commits into from

Conversation

@AsnelChristian
Copy link
Member

@AsnelChristian AsnelChristian commented Jun 25, 2017

No description provided.

@AsnelChristian AsnelChristian force-pushed the master branch 8 times, most recently from d28e7c1 to f40d81f Compare June 26, 2017 15:25
@AsnelChristian AsnelChristian force-pushed the master branch 6 times, most recently from f84aada to 7661561 Compare July 6, 2017 21:10
@AsnelChristian AsnelChristian force-pushed the master branch 4 times, most recently from 351a83f to 4ce170f Compare July 27, 2017 10:07
@AsnelChristian AsnelChristian changed the title WIP: Docs Update Docs Update Jul 27, 2017
jayvdb
jayvdb reviewed Jul 27, 2017
View reviewed changes
Copy link
Member

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit message

jayvdb
jayvdb requested changes Jul 27, 2017
View reviewed changes
Copy link
Member

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit message

jayvdb
jayvdb requested changes Jul 27, 2017
View reviewed changes
Root/Formatting/README.rst
* `Length <Length/README.rst>`_
* `Quotation <Quotation/README.rst>`_
* `Spacing <Spacing/README.rst>`_
Example
Copy link
Member

@jayvdb jayvdb Jul 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line above this.

Copy link
Member Author

@AsnelChristian AsnelChristian Jul 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is automatically generated, do you want me to modify the function that generates it

Copy link
Member

@jayvdb jayvdb Jul 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes please.

Copy link
Member Author

@AsnelChristian AsnelChristian Jul 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

@AsnelChristian
generate: Add newline after Index
236de7c 
Adds a blank line after the first line containing the
links to the parent aspect and the index.
@AsnelChristian
Docs Update
9e52c02 
Updates the documentation about the Smell and
Spelling aspects and their subaspects as the were modified,
and adds documentation about the Formatting aspect
that was added.
@AsnelChristian
Copy link
Member Author

AsnelChristian commented Jul 27, 2017

Commit message updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jayvdb jayvdb jayvdb requested changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AsnelChristian @jayvdb