Skip to content

Require self-assessed technical and governance reviews for matriculation#2114

Merged
brandtkeller merged 2 commits intocncf:mainfrom
joshgav:review-template
May 6, 2026
Merged

Require self-assessed technical and governance reviews for matriculation#2114
brandtkeller merged 2 commits intocncf:mainfrom
joshgav:review-template

Conversation

@joshgav
Copy link
Copy Markdown
Contributor

@joshgav joshgav commented Apr 16, 2026

This PR proposes requiring preliminary self-assessed technical and governance reviews for incoming and matriculating projects. It's based on consensus reached in the project-reviews subproject on 2026-01-22. We determined then that projects should complete their own technical reviews ("GTR") and that technical presentations to TAGs should be secondary and optional, with a process for such presentations yet to be determined. CNCF reviewers will then take a project's technical self-assessment, verify it and commit it to the cncf/toc repo, as they do for governance reviews today.

This PR also proposes a congruent process for governance reviews: a project will self-assess a governance review like the technical review prior to requesting matriculation. Projects already do exactly this today inline in matriculation issues, so this just asks them to save the assessment somewhere alongside their technical review rather than only including answers in the issue.

Ultimately, the idea is that this will lead to technical, governance, and security reviews being saved and persisted by a project, e.g., in a community or .project repo, and referenced from matriculation issues, rather than being inline in the matriculation issue itself. This will make review docs easier to maintain and iterate upon for projects and easier for users to discover.

@joshgav joshgav requested review from a team as code owners April 16, 2026 19:35
Signed-off-by: Josh Gavant <joshgavant@gmail.com>
@JustinCappos
Copy link
Copy Markdown
Contributor

+1

This is a welcome addition! Hope to see it go through!

Copy link
Copy Markdown
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing thought on issue template. Still reviewing updates.

Comment thread .github/ISSUE_TEMPLATE/template-graduation-application.md Outdated
@angellk
Copy link
Copy Markdown
Contributor

angellk commented Apr 17, 2026

This needs to be discussed by the TOC - thank you for the recommendation from the Subproject @joshgav

@github-actions github-actions Bot added the needs-triage Indicates an issue or PR that has not been triaged yet (has a 'triage/foo' label applied) label Apr 22, 2026
@github-actions github-actions Bot added the needs-kind Indicates an issue or PR that is missing an issue type or kind (a kind/foo label) label Apr 22, 2026
@github-actions github-actions Bot added the needs-group Indicates an issue or PR that has not been assigned a group (toc or tag/foo label applied) label Apr 22, 2026
Co-authored-by: Brandt Keller <43887158+brandtkeller@users.noreply.github.com>
Signed-off-by: Karena Angell <kangell@redhat.com>
Copy link
Copy Markdown
Contributor

@angellk angellk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This was discussed by the TOC and this update is very appreciated @joshgav

@angellk angellk requested a review from brandtkeller May 6, 2026 12:13
@brandtkeller brandtkeller merged commit 518989e into cncf:main May 6, 2026
2 checks passed
@github-project-automation github-project-automation Bot moved this from New to Done in CNCF TOC Board May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-group Indicates an issue or PR that has not been assigned a group (toc or tag/foo label applied) needs-kind Indicates an issue or PR that is missing an issue type or kind (a kind/foo label) needs-triage Indicates an issue or PR that has not been triaged yet (has a 'triage/foo' label applied)

Projects

Status: Done
Status: No status
Status: No status
Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants