ci: declare least-privilege permissions in workflows#354
Merged
Conversation
✅ Deploy Preview for cncf-techdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- format-check, link-check, spell-check: contents: read (PR-time
read-only checks).
- trigger-contribute-site-netlify: permissions: {} (only POSTs to the
Netlify build webhook).
Signed-off-by: arpitjain099 <arpitjain099@gmail.com>
arpitjain099
force-pushed
the
ci/add-permissions
branch
from
f346df4 to
82c0903
Compare
There was a problem hiding this comment.
Pull request overview
This PR tightens GitHub Actions least-privilege settings by explicitly declaring GITHUB_TOKEN permissions on the remaining workflows that were inheriting broader org defaults.
Changes:
- Set
permissions: {}for the Netlify build-hook workflow that only POSTs to an external webhook. - Set
permissions: contents: readfor formatting, link, and spelling check workflows that checkout the repo and run read-only validation scripts.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/trigger-contribute-site-netlify.yml | Declares zero GITHUB_TOKEN permissions for a webhook-only workflow. |
| .github/workflows/spell-check.yml | Restricts token scope to contents: read for PR-time spelling checks. |
| .github/workflows/link-check.yml | Restricts token scope to contents: read for PR-time link checks. |
| .github/workflows/format-check.yml | Restricts token scope to contents: read for PR-time formatting/markdown lint checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Patrice Chalin <chalin@users.noreply.github.com>
chalin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins the default
GITHUB_TOKENon the four workflows still inheriting org defaults:format-check.yml,link-check.yml,spell-check.yml—contents: read. PR-time read-only checks (npm run check:format/markdown/links/spelling).trigger-contribute-site-netlify.yml—permissions: {}. The job only POSTs toNETLIFY_CONTRIBUTE_SITE_BUILD_HOOK; no checkout, no GitHub API calls.YAML validated locally.