Conversation
cmfcmf
left a comment
There was a problem hiding this comment.
Hey @MichaelBuessemeyer,
thanks a lot for this PR! One thing that I would like to discuss is the addition of eslint. I think it is slightly overkill for this project and I am slightly in favor of not adding it (but you can definitely convince me otherwise).
Also, I would prefer if you added just two new scripts to package.json: format and lint, that run prettier (and possibly eslint), where format is a combination of the current pretty and lint-fix scripts and lint is a combination of am-i-pretty and lint.
combine yarn commands; remove unused dependecies; adjust eslint rules
Your welcome :)
I understand that you think that eslint is overkill. But it has the advantage that it lints the code 😅 . This prevent some errors that might not be obvious at first sight. I only found the error in I am fine if you do not want it as a dependency. But i'll use it in #13 anyway to prevent myself from writing error that the linter can catch easily.
Alrighty 🐈 |
|
Alright, thank you! I re-added |
This PR adds prettier as a formatter and eslint as a linter.
We use eslint as a linter and not prettier as eslint is more capable & has more features as far as I know.
Happy to hear / read your suggestions :)