Upgrade Guava library to version 32.0.0-jre in CDAP common module#18
Open
dheeraj-kholia-cs wants to merge 1 commit intoguava-library-upgradefrom
Open
Upgrade Guava library to version 32.0.0-jre in CDAP common module#18dheeraj-kholia-cs wants to merge 1 commit intoguava-library-upgradefrom
dheeraj-kholia-cs wants to merge 1 commit intoguava-library-upgradefrom
Conversation
- Updated the Guava dependency version in `pom.xml` to 32.0.0-jre. - Ensured compatibility with the upgraded Guava version.
| @@ -0,0 +1,38 @@ | |||
| /* | |||
| * Copyright © 2024 Cask Data, Inc. | |||
Collaborator
There was a problem hiding this comment.
change the year to 2026 in all new files
| @Override | ||
| public void finished(HttpResponder responder) { | ||
| Closeables.closeQuietly(outputStream); | ||
| try { if (outputStream != null) outputStream.close(); } catch (IOException ignored) { } |
Collaborator
There was a problem hiding this comment.
use curly braces in if conditions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pom.xmlto 32.0.0-jre.