Bump cloudstack-go SDK to v2.19.1 - #8
Merged
Merged
Conversation
Collaborator
Author
|
@elivlo can you please review this. Thanks. |
Of course, I will do that! I have completely missed the your mention :/ |
|
@Pearl1594 I rebased this branch locally and ran the CSI in my local cluster. It is working just fine! LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Updates go-sdk to v2.19.1
What was actually run:
go get github.com/apache/cloudstack-go/v2@v2.19.1
go mod tidy
go build ./..., go vet ./..., go test ./...
Testing performed:
$ go test ./...
? github.com/cloudstack/cloudstack-csi-driver/cmd/cloudstack-csi-driver [no test files]
? github.com/cloudstack/cloudstack-csi-driver/cmd/cloudstack-csi-sc-syncer [no test files]
? github.com/cloudstack/cloudstack-csi-driver/pkg/cloud [no test files]
? github.com/cloudstack/cloudstack-csi-driver/pkg/cloud/fake [no test files]
ok github.com/cloudstack/cloudstack-csi-driver/pkg/driver (cached)
? github.com/cloudstack/cloudstack-csi-driver/pkg/mount [no test files]
ok github.com/cloudstack/cloudstack-csi-driver/pkg/syncer (cached)
ok github.com/cloudstack/cloudstack-csi-driver/pkg/util (cached)