feat: Add design token for tooltip enter animation#4829
Merged
Conversation
jperals
force-pushed
the
dev-v3-jotresse-tooltip-enter-animation
branch
from
July 24, 2026 09:33
6edaa22 to
792ce2c
Compare
jperals
changed the title
jperals
commented
Jul 24, 2026
|
|
||
| // Theming generates inline styles in runtime | ||
| if (location.hash.includes('theming') || location.hash.includes('side-navigation/collapsed')) { | ||
| if (location.hash.includes('theming') || location.hash.includes('side-navigation/collapsed') || location.hash.includes('tooltip/motion')) { |
Member
Author
There was a problem hiding this comment.
This is needed in order to use applyTheme in the new page
| <div | ||
| {...baseProps} | ||
| className={clsx(testUtilStyles.root, baseProps.className)} | ||
| className={clsx(testUtilStyles.root, styles.root)} |
Member
There was a problem hiding this comment.
shouldn't baseProps.className be retained as well?
Member
Author
There was a problem hiding this comment.
Yes, thank you, added back
jperals
force-pushed
the
dev-v3-jotresse-tooltip-enter-animation
branch
from
July 24, 2026 11:01
fefe510 to
b70fe8c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4829 +/- ##
=======================================
Coverage 97.61% 97.61%
=======================================
Files 952 952
Lines 30816 30816
Branches 11318 11318
=======================================
Hits 30081 30081
Misses 688 688
Partials 47 47 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jperals
enabled auto-merge
July 24, 2026 14:31
gethinwebster
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds design token for tooltip enter animation
How has this been tested?
Manually, on the new dev page.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.