Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ function getResourceTypeElements(container: HTMLElement) {

jest.mock('../../../lib/components/internal/hooks/use-visual-mode', () => ({
useVisualRefresh: jest.fn().mockReturnValue(false),
useOneTheme: jest.fn().mockReturnValue(false),
}));

describe('Classic design', () => {
Expand Down
1 change: 1 addition & 0 deletions src/container/__tests__/sticky-header.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ jest.mock('../../../lib/components/internal/hooks/use-mobile', () => ({
}));
jest.mock('../../internal/hooks/use-visual-mode', () => ({
useVisualRefresh: jest.fn().mockReturnValue(true),
useOneTheme: jest.fn().mockReturnValue(false),
}));

jest.mock('@cloudscape-design/component-toolkit/dom', () => ({
Expand Down
1 change: 1 addition & 0 deletions src/content-layout/__tests__/content-layout.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import styles from '../../../lib/components/content-layout/styles.selectors.js';

jest.mock('../../../lib/components/internal/hooks/use-visual-mode', () => ({
useVisualRefresh: jest.fn().mockReturnValue(false),
useOneTheme: jest.fn().mockReturnValue(false),
}));

function renderContentLayout(props: ContentLayoutProps = {}) {
Expand Down
1 change: 1 addition & 0 deletions src/header/__tests__/sticky-responsiveness.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import styles from '../../../lib/components/header/styles.css.js';

jest.mock('../../../lib/components/internal/hooks/use-visual-mode', () => ({
useVisualRefresh: jest.fn().mockReturnValue(false),
useOneTheme: jest.fn().mockReturnValue(false),
}));

function renderHeader(jsx: React.ReactElement) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,24 @@ describe('usePortalModeClasses', () => {
expect(screen.getByTestId('subject')).toHaveClass('awsui-visual-refresh', { exact: true });
});

test('should detect one theme mode', () => {
document.body.classList.add('awsui-one-theme');

render(<RenderTest refClasses="" />);
expect(screen.getByTestId('subject')).toHaveClass('awsui-one-theme', { exact: true });
// Must not stamp the VR class, which would override One Theme tokens on portaled content.
expect(screen.getByTestId('subject')).not.toHaveClass('awsui-visual-refresh');
});

test('should let one theme win when visual refresh is also active', () => {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want One Theme to win over Visual Refresh?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We can have pages with .awsui-visual-refresh AND with .awsui-one-theme classes. In that case, one theme should shown.

globalWithFlags[Symbol.for('awsui-visual-refresh-flag')] = () => true;
document.body.classList.add('awsui-one-theme');

render(<RenderTest refClasses="" />);
expect(screen.getByTestId('subject')).toHaveClass('awsui-one-theme', { exact: true });
expect(screen.getByTestId('subject')).not.toHaveClass('awsui-visual-refresh');
});

test('should detect contexts', () => {
render(
<VisualContext contextName="content-header">
Expand Down
6 changes: 4 additions & 2 deletions src/internal/hooks/use-portal-mode-classes/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,20 @@ import { useCurrentMode, useDensityMode } from '@cloudscape-design/component-too

import { useVisualContext } from '../../components/visual-context';
import { ALWAYS_VISUAL_REFRESH } from '../../environment';
import { useVisualRefresh } from '../use-visual-mode';
import { useOneTheme, useVisualRefresh } from '../use-visual-mode';

export function usePortalModeClasses(ref: React.RefObject<HTMLElement>, options?: { resetVisualContext?: boolean }) {
const colorMode = useCurrentMode(ref);
const densityMode = useDensityMode(ref);
const context = useVisualContext(ref);
const visualRefreshWithClass = useVisualRefresh() && !ALWAYS_VISUAL_REFRESH;
const oneTheme = useOneTheme();
const visualRefreshWithClass = useVisualRefresh() && !ALWAYS_VISUAL_REFRESH && !oneTheme;

return clsx({
'awsui-polaris-dark-mode awsui-dark-mode': colorMode === 'dark',
'awsui-polaris-compact-mode awsui-compact-mode': densityMode === 'compact',
'awsui-visual-refresh': visualRefreshWithClass,
'awsui-one-theme': oneTheme,
[`awsui-context-${context}`]: context && !options?.resetVisualContext,
});
}
4 changes: 3 additions & 1 deletion src/internal/hooks/use-visual-mode/index.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0

import { useRuntimeVisualRefresh } from '@cloudscape-design/component-toolkit/internal';
import { isThemeActive, Theme, useRuntimeVisualRefresh } from '@cloudscape-design/component-toolkit/internal';

import { ALWAYS_VISUAL_REFRESH } from '../../environment';

export const useVisualRefresh = ALWAYS_VISUAL_REFRESH ? () => true : useRuntimeVisualRefresh;

export const useOneTheme = () => isThemeActive(Theme.OneTheme);
1 change: 1 addition & 0 deletions src/internal/widgets/__tests__/widgets.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ function findContent(container: HTMLElement) {

jest.mock('../../../../lib/components/internal/hooks/use-visual-mode', () => ({
useVisualRefresh: jest.fn().mockReturnValue(false),
useOneTheme: jest.fn().mockReturnValue(false),
}));

describe('Classic design', () => {
Expand Down
1 change: 1 addition & 0 deletions src/split-panel/__tests__/widgetized-panel.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ const defaultProps: SplitPanelImplementationProps = {

jest.mock('../../../lib/components/internal/hooks/use-visual-mode', () => ({
useVisualRefresh: jest.fn().mockReturnValue(false),
useOneTheme: jest.fn().mockReturnValue(false),
}));

describe('Classic design', () => {
Expand Down
1 change: 1 addition & 0 deletions src/wizard/__tests__/analytics-metadata.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import labels from '../../../lib/components/wizard/analytics-metadata/styles.css

jest.mock('../../../lib/components/internal/hooks/use-visual-mode', () => ({
useVisualRefresh: jest.fn().mockReturnValue(false),
useOneTheme: jest.fn().mockReturnValue(false),
}));

const steps: WizardProps['steps'] = [
Expand Down
Loading