Skip to content

chore: Table Column Groups Followups#4597

Merged
NathanZlion merged 5 commits into
mainfrom
chore/table-column-groups-cleanup
Jun 11, 2026
Merged

chore: Table Column Groups Followups#4597
NathanZlion merged 5 commits into
mainfrom
chore/table-column-groups-cleanup

Conversation

@NathanZlion

@NathanZlion NathanZlion commented Jun 10, 2026

Copy link
Copy Markdown
Member

Following up on #4482

Fix missing highcontrast horizontal line divider between levels.

  • fix: use higher-contrast border color for sticky table header divider

Unintended less contract color divider.
image

What we want consistently for all table feature combinations
image

Updating the Test Page to include collection prefs on the grouped table dev page

  • chore: add CollectionPreferences to column-groups dev page

Description

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Aligns the sticky header border with the non-sticky variant to ensure
consistent contrast across all table configurations.
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.50%. Comparing base (17860b0) to head (9aa1870).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4597   +/-   ##
=======================================
  Coverage   97.50%   97.50%           
=======================================
  Files         948      948           
  Lines       30262    30262           
  Branches    11026    11026           
=======================================
  Hits        29507    29507           
  Misses        748      748           
  Partials        7        7           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread pages/table/column-groups.page.tsx Outdated
Allows toggling column visibility, grouping, wrap lines, striped rows,
and content density to better exercise grouped tables in dev/manual
testing.
Comment thread pages/table/column-groups.page.tsx Outdated
… and table

These were added coz there was no way to control these without collection prefs, and the 2 PRs were raised separately but now we merged them so can be done inside the collection-prefs
@NathanZlion NathanZlion added this pull request to the merge queue Jun 10, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 10, 2026
@NathanZlion NathanZlion added this pull request to the merge queue Jun 11, 2026
Merged via the queue into main with commit 5d72a97 Jun 11, 2026
51 checks passed
@NathanZlion NathanZlion deleted the chore/table-column-groups-cleanup branch June 11, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants