Skip to content

feat: add renderContent and visualContext props to top navigation#4594

Draft
amanabiy wants to merge 7 commits into
mainfrom
dev-v3-amanabiy-top-nav-custom-content
Draft

feat: add renderContent and visualContext props to top navigation#4594
amanabiy wants to merge 7 commits into
mainfrom
dev-v3-amanabiy-top-nav-custom-content

Conversation

@amanabiy

@amanabiy amanabiy commented Jun 9, 2026

Copy link
Copy Markdown
Member

Description

Don't worry about the naming of the props, and that it is not a slot. Try to review the other things if possible.

Adds two new props to TopNavigation:

  • renderContent: a render function that replaces all structured content (identity, search, utilities). Gives consumers full control over the navigation bar content.
  • visualContext: controls whether the dark branded color scheme is applied ("top-navigation", default) or not ("none").

Additionally, identity becomes optional

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.35294% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.51%. Comparing base (c158a47) to head (68d3e78).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/top-navigation/internal.tsx 80.64% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4594      +/-   ##
==========================================
+ Coverage   97.50%   97.51%   +0.01%     
==========================================
  Files         947      948       +1     
  Lines       30244    30291      +47     
  Branches    11016    11052      +36     
==========================================
+ Hits        29489    29538      +49     
+ Misses        748      706      -42     
- Partials        7       47      +40     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@amanabiy amanabiy force-pushed the dev-v3-amanabiy-top-nav-custom-content branch from 87d71bd to 0704bfc Compare June 10, 2026 12:19
@amanabiy amanabiy force-pushed the dev-v3-amanabiy-top-nav-custom-content branch 2 times, most recently from a062fb7 to 6909417 Compare June 10, 2026 12:40
@amanabiy amanabiy force-pushed the dev-v3-amanabiy-top-nav-custom-content branch 2 times, most recently from e1e1f88 to 7091433 Compare June 11, 2026 07:51
@amanabiy amanabiy force-pushed the dev-v3-amanabiy-top-nav-custom-content branch from 7091433 to 9f18080 Compare June 11, 2026 08:01
@amanabiy amanabiy force-pushed the dev-v3-amanabiy-top-nav-custom-content branch from 9f18080 to e65211b Compare June 11, 2026 08:22
@amanabiy amanabiy force-pushed the dev-v3-amanabiy-top-nav-custom-content branch from e65211b to 727266d Compare June 11, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant