feat: add renderContent and visualContext props to top navigation#4594
Draft
amanabiy wants to merge 7 commits into
Draft
feat: add renderContent and visualContext props to top navigation#4594amanabiy wants to merge 7 commits into
amanabiy wants to merge 7 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4594 +/- ##
==========================================
+ Coverage 97.50% 97.51% +0.01%
==========================================
Files 947 948 +1
Lines 30244 30291 +47
Branches 11016 11052 +36
==========================================
+ Hits 29489 29538 +49
+ Misses 748 706 -42
- Partials 7 47 +40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
87d71bd to
0704bfc
Compare
a062fb7 to
6909417
Compare
e1e1f88 to
7091433
Compare
7091433 to
9f18080
Compare
9f18080 to
e65211b
Compare
e65211b to
727266d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Don't worry about the naming of the props, and that it is not a slot. Try to review the other things if possible.
Adds two new props to TopNavigation:
renderContent: a render function that replaces all structured content (identity, search, utilities). Gives consumers full control over the navigation bar content.visualContext: controls whether the dark branded color scheme is applied ("top-navigation", default) or not ("none").Additionally,
identitybecomes optionalRelated links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.