chore: Implement one-theme icon#4588
Draft
at-susie wants to merge 5 commits into
Draft
Conversation
…elector Replace :global(.awsui-one-theme) ancestor selector with a local .one-theme CSS class on the icon span, following the same pattern as the .refresh class in cards. The one-theme class is applied via isThemeActive(Theme.OneTheme) in clsx, removing the need for the selector-combinator-disallowed-list stylelint suppression comment.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4588 +/- ##
==========================================
+ Coverage 97.45% 97.50% +0.05%
==========================================
Files 942 947 +5
Lines 29716 30253 +537
Branches 10800 11027 +227
==========================================
+ Hits 28959 29498 +539
+ Misses 710 708 -2
Partials 47 47 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements one-theme specific icon treatments.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.