-
Notifications
You must be signed in to change notification settings - Fork 231
chore: Fix downstream build failures introduced by #4514 #4566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
at-susie
wants to merge
14
commits into
main
Choose a base branch
from
fix/icon-size
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
441efec
chore: Add null guard and fix SCSS max() function interpolation
at-susie 36c7244
chore: Revert the change in the scss mixin
at-susie 2d96548
chore: Remove comment
at-susie 6e7bd4a
chore: Simplify size override computation with nullish coalescing
at-susie 7ea181d
chore: Replace nullish coalescing with explicit null guards in comput…
at-susie 0cb5e19
Merge branch 'main' into fix/icon-size
at-susie b7aec3e
chore: Add null guard tests for missing context fields
at-susie 5803e4e
chore: Remove comment
at-susie a745893
Merge branch 'main' into fix/icon-size
at-susie ae29623
chore: Use wrapper(container).findIcon() and .getElement()
at-susie 03e7658
chore: Add undefined type to size override parameters
at-susie 8adf061
chore: Add tests for missing context fields in IconProvider
at-susie bfacc3f
chore: Add test for undefined sizeOverrides and strokeWidthOverrides
at-susie 203d2d4
Merge branch 'main' into fix/icon-size
at-susie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can
sizeOverridesandstrokeWidthOverridesbe undefined in the first place if they are required in the function signature?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Updated the parameter types to | undefined to make this explicit.