-
Notifications
You must be signed in to change notification settings - Fork 11
add snapshot create delete capability #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
disperate
wants to merge
43
commits into
cloudscale-ch:master
Choose a base branch
from
disperate:julian/add-snapshot-create-delete-capability
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
57c44ea
add create and delete snapshot capability
disperate fdd653e
add csi-snapshotter sidecar
disperate ebf1153
Merge branch 'master' into julian/add-snapshot-create-delete-capability
disperate 226e604
fix for existing snapshots on other volumes
disperate 9177b94
Merge remote-tracking branch 'upstream/upgrade-go-1.25' into julian/a…
disperate a731ebe
add integraiton test covering creation and deletion of snapshot
disperate aa6bedb
add integration test creating a new volume from a snapshot
disperate eaa650c
improve error handling in CreateSnapshot if snapshot does not exist
disperate 9bc534f
Merge branch 'master' into julian/add-snapshot-create-delete-capability
disperate a70fa50
improve error message formating
disperate bb3f558
fix error formatting
disperate 68317ca
add integration test for luks volume
disperate 000c1d9
add integration test for PVCs with wrong size
disperate 576bd5a
add examples, including luks
disperate ec91d70
remove volume group snapshot permissions
disperate 6180be8
add propper permission role and bindings
disperate 1186d23
explain reason for DynamicSnapshotClient
disperate c3e163c
get rid of dynamicClient, use typed clientset from external-snapshotter
disperate 73a757f
use errors.As to prevent issues with wraped errors
disperate d376c0b
throw InvalidArgument instead of warning for storageType missmatch
disperate 760a5c7
improve error handling of existing snapshots and log levels
disperate 40920be
simplify createdAt parsing
disperate f044acf
shorten compared error message
disperate 567d561
replace custom CRD and snapshot controller installation with kustomize
disperate c8de277
ignoring storage type parameter, only add debug information
disperate da0b949
setup instructions for volumesnapshotclass.yaml
disperate 9436917
remove leader-election config, as we run it on single replica
disperate 23d371c
add documentation for luks examples
disperate 64768a1
fail integration tests with clear error if CRDs or VolumeSnapshotClas…
disperate b84e9a2
fix volume and snapshot cleanup in TestPod_Create_Volume_From_Snapshot
disperate 44c0954
cleanup luks examples
disperate fe09ed2
cleanup volume snapshot examples, prevent naming conflict
disperate 4a98d81
remove unnecessary if in driver/controller.go
disperate 509d43b
fix typo in test/kubernetes/integration_test.go
disperate 64f2d90
replace static log level with .Values.snapshotter.logLevelVerbosity
disperate f81b6e6
improve check for existing snapshots
disperate 9065025
wire up resources into helm chart
disperate 6b54627
Apply suggestion from @mweibel, simplify error creation
disperate 765446d
improve idempodency handling and csiVolume creation for createVolumeF…
disperate ddb32a6
cleanup logging, comments and error code if size does not match
disperate ae5d884
Merge branch 'julian/add-snapshot-create-delete-capability' of github…
disperate 93ad635
remove TestPod_Single_SSD_Volume_Snapshot as it is already covered in…
disperate 60ef0a5
fix return code and add save guard to fake driver volume deletion
disperate File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -72,6 +72,21 @@ spec: | |
| volumeMounts: | ||
| - name: socket-dir | ||
| mountPath: /var/lib/csi/sockets/pluginproxy/ | ||
| - name: csi-snapshotter | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. because of the additional setup required (installing CRDs and the controller), I wonder if we should make this sidecar optional (i.e. add an |
||
| image: "{{ .Values.snapshotter.image.registry }}/{{ .Values.snapshotter.image.repository }}:{{ .Values.snapshotter.image.tag }}" | ||
| args: | ||
| - "--csi-address=$(CSI_ENDPOINT)" | ||
| - "--v={{ .Values.snapshotter.logLevelVerbosity }}" | ||
| {{- with .Values.controller.resources }} | ||
| resources: | ||
| {{ toYaml . | indent 12 }} | ||
| {{- end }} | ||
| env: | ||
| - name: CSI_ENDPOINT | ||
| value: unix:///var/lib/csi/sockets/pluginproxy/csi.sock | ||
| volumeMounts: | ||
| - name: socket-dir | ||
| mountPath: /var/lib/csi/sockets/pluginproxy/ | ||
| - name: csi-cloudscale-plugin | ||
| image: "{{ .Values.controller.image.registry }}/{{ .Values.controller.image.repository }}:{{ .Values.controller.image.tag }}" | ||
| args : | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we misunderstood each other in the first review.
I'd keep these in, because external-provisioner has them as well.
In the end it doesn't really matter because snapshotter-role also maps those to the same SA but I think updating later to newer provisioner versions with potentially updated role definitions makes the update easier.