Conversation
gaudenz
left a comment
There was a problem hiding this comment.
I'm a bit unsure about the list of fixtures. Do we really need the access_key and secret_key fixtures? Isn't the objects_user fixture good enough for this?
On the other hand an s3_client and sns_client fixture might be handy. I see that constructing the client once in the test to show how to do it is nice, but if we grow this test suite, I might become repetitive.
On the other hand even the object_user fixture is debatable because we probably also want to have tests covering objects user and key creation.
I personally err on the side of too many fixtures: They are cheap, simple, and easy to understand. If it makes the code in front a bit nicer to read, they should be included.
My thought exactly, but since I don't have additional tests yet, I think this would be premature.
For that the |
34537f9 to
41fd24b
Compare
This adds an initial set of S3 tests.