-
Notifications
You must be signed in to change notification settings - Fork 45
feat: add support for DefaultAzureCredential authentication mechanism #681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This commit adds support for the DefaultAzureCredential authentication mechanism in Azure Blob Storage. Users can now use the `useDefaultAzureCredentials` option to enable Azure's default credential chain, which automatically discovers and uses available credentials in the following order Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
| // When using default Azure credentials, no secrets are required | ||
| if !barmanCredentials.Azure.UseDefaultAzureCredentials { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we include also barmanCredentials.Azure.InheritFromAzureAD here?
| // When using default Azure credentials, no secrets are required | |
| if !barmanCredentials.Azure.UseDefaultAzureCredentials { | |
| // When using default Azure credentials or AzureAD, no secrets are required | |
| if !barmanCredentials.Azure.UseDefaultAzureCredentials && !barmanCredentials.Azure.InheritFromAzureAD { |
| This is particularly useful when running on Azure Kubernetes Service (AKS) with | ||
| [Workload Identity](https://learn.microsoft.com/en-us/azure/aks/workload-identity-overview): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this assessment is totally precise. I think Azure Default Credentials are primarily useful to delegate to the SDK the auth mechanism inferring it from the environment, so that different auth methods can be used in different environments seamlessly.
|
@armru the manifests generation seems to be missing in this PR |
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
…g#681) Make explicit in docs that the inheritFromAzureAD option enables the usage of Azure Managed Identity authentication mechanism. Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
…g#681) Make explicit in docs that the inheritFromAzureAD option enables the usage of Azure Managed Identity authentication mechanism. Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
This commit adds support for the DefaultAzureCredential authentication mechanism in Azure Blob Storage. Users can now use the
useDefaultAzureCredentialsoption to enable Azure's default credential chain, which automatically discovers and uses available credentials in the following orderThis is particularly useful when running on Azure Kubernetes Service (AKS) with
Workload Identity, eliminating the need to explicitly store credentials in
Kubernetes Secrets.