Skip to content

Conversation

@GabriFedi97
Copy link
Contributor

@GabriFedi97 GabriFedi97 commented Nov 14, 2025

Add support for authenticating to Azure via DefaultAzureCredential.
If the annotation barmancloud.cnpg.io/useDefaultAzureCredentials="true" is detected on the ObjectStore, in addition of setting the value .spec.configuration.azureCredentials.inheritFromAzureAD: true, the barman-cloud commands will be executed to use DefaultAzureCredential.

Fixes #662

Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
@GabriFedi97 GabriFedi97 force-pushed the feat/azure-default-creds branch from 02915f4 to 1c3dd85 Compare November 14, 2025 15:21
Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
@GabriFedi97 GabriFedi97 marked this pull request as ready for review November 18, 2025 08:19
@GabriFedi97 GabriFedi97 requested a review from a team as a code owner November 18, 2025 08:19
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Nov 18, 2025
Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
Signed-off-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com>
@GabriFedi97 GabriFedi97 force-pushed the feat/azure-default-creds branch from a4fbd84 to 2cb76ef Compare November 18, 2025 08:32
@mnencia
Copy link
Member

mnencia commented Nov 18, 2025

We should not go ahead with this patch. Barman has added an explicit default option to the --azure-credential option. The API is stable, so we need to update github.com/cloudnative-pg/barman-cloud to support it and change the ObjectStore definition accordingly.

@amnesia0287
Copy link

We should not go ahead with this patch. Barman has added an explicit default option to the --azure-credential option. The API is stable, so we need to update github.com/cloudnative-pg/barman-cloud to support it and change the ObjectStore definition accordingly.

Do you know if that work is planned? Cause all I can find mentioned is this cloudnative-pg/barman-cloud#115 but that’s much older than this ticket.

@amnesia0287
Copy link

We should not go ahead with this patch. Barman has added an explicit default option to the --azure-credential option. The API is stable, so we need to update github.com/cloudnative-pg/barman-cloud to support it and change the ObjectStore definition accordingly.

Actually reviewing cloudnative-pg/barman-cloud#59 and https://github.com/cloudnative-pg/barman-cloud/pull/64/files

Does this not already chain to your linked commit and pass default in? Or can we not set the context flag without https://github.com/cloudnative-pg/barman-cloud/pull/115/files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add DefaultAzureCredential auth mechanism support

3 participants