feat(deployment): adds revisionHistoryLimit as a configurable parameter#925
Open
NPastorale wants to merge 1 commit into
Open
feat(deployment): adds revisionHistoryLimit as a configurable parameter#925NPastorale wants to merge 1 commit into
NPastorale wants to merge 1 commit into
Conversation
NPastorale
requested review from
fcanovai,
gbartolini,
itay-grudev,
leonardoce and
mnencia
as code owners
dosubot
Bot
added
the
size:XS
Signed-off-by: NPastorale <npastorale@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
revisionHistoryLimitas a configurable chart value for the CloudNativePG operator DeploymentMotivation
Some environments may prefer retaining fewer ReplicaSets to avoid unnecessary clutter, while others might require more. Exposing
revisionHistoryLimitas a chart value provides additional flexibility without changing the current default behaviour.This is a common parameter exposed by many charts and as such, users may expect it to be configurable (me included).
Given the infinitesimality and low risk of the change, I've taken the liberty of not opening an issue beforehand. Do let me know whether you'd like me to open one regardless.
Backwards compatibility
10, matching the Kubernetes default