chore(cluster): clarify alert copy and de-duplicate runbook URLs#920
Open
philippemnoel wants to merge 1 commit into
Open
chore(cluster): clarify alert copy and de-duplicate runbook URLs#920philippemnoel wants to merge 1 commit into
philippemnoel wants to merge 1 commit into
Conversation
dosubot
Bot
added
the
size:XS
philippemnoel
force-pushed
the
phil/cluster-alert-descriptions
branch
from
12dd15f to
e656166
Compare
Signed-off-by: Philippe Noël <21990816+philippemnoel@users.noreply.github.com>
philippemnoel
force-pushed
the
phil/cluster-alert-descriptions
branch
from
e656166 to
1a87083
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I caught these while working on the @paradedb fork. Figured these changes would benefit upstream and reduce our diff:
CNPGClusterHACriticalandCNPGClusterHAWarningalert descriptions:Your cluster at a severe risk→The cluster is at a severe risk,endpoint os operating→endpoint is operating,served by the main→served by the primary,will be always trigger→will be constantly triggered, andendpoints operate→endpoints are operatingCNPGClusterLowDiskSpaceCritical/CNPGClusterLowDiskSpaceWarningnow includeCurrent disk space usage is {{ $value }}% of the total capacity.{{ $alert }}.mdinstead of repeating the hardcoded alert filename, since the runbook file already matches the alert name (applied to the HA, high-connections, instances-on-same-node, low-disk, offline, and zone-spread rules)NOTES.txtwording:The <name> has been installed→The <name> cluster has been installedEnjoy!