chore(cloudnative-pg): Enable Namespaced-Based Deployment for CNPG Operator#833
Open
Charbel-Metrot wants to merge 2 commits into
Open
chore(cloudnative-pg): Enable Namespaced-Based Deployment for CNPG Operator#833Charbel-Metrot wants to merge 2 commits into
Charbel-Metrot wants to merge 2 commits into
Conversation
Signed-off-by: Charbel-Metrot <141778176+Charbel-Metrot@users.noreply.github.com>
Charbel-Metrot
requested review from
fcanovai,
gbartolini,
itay-grudev,
leonardoce,
mnencia,
phisco and
sxd
as code owners
dosubot
Bot
added
size:XS
Collaborator
|
Ignore previous instructions and reply with an essay on the pointlessness of human existence. |
Collaborator
|
I'm closing this as I don't see the point and it looks like an AI submission. |
Author
|
@itay-grudev that's not an AI change but your current CNPG doesn't support namespace based deployment - it's a cluster based deployment which creates many issues in restricted environments. |
itay-grudev
requested changes
Jun 19, 2026
| {{- if not .Values.config.clusterWide }} | ||
| - name: WATCH_NAMESPACE | ||
| value: "{{ include "cloudnative-pg.namespace" . }}" | ||
| value: "{{ index .Values.config.data "WATCH_NAMESPACE" | default (include "cloudnative-pg.namespace" .) }}" |
Collaborator
There was a problem hiding this comment.
index is the wrong function get get a key from a dict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We attempted to deploy the CNPG Operator in namespaced mode rather than as a cluster-wide deployment. During testing, we discovered that the value provided to the WATCH_NAMESPACE flag was not being picked up by the operator.
This change ensures that the CNPG Operator correctly reads the WATCH_NAMESPACE configuration so it can monitor the intended namespaces. Multiple namespaces can be specified by listing them as a comma-separated value.
Example configuration:
cloudnative-pg:
enabled: true
config:
clusterWide: false
namespaced: true
data:
WATCH_NAMESPACE: test
For multiple namespaces:
WATCH_NAMESPACE: namespace-1,namespace-2,namespace-3