fix(cluster): fix alert templating and replica secret config#828
Open
philippemnoel wants to merge 1 commit into
Open
fix(cluster): fix alert templating and replica secret config#828philippemnoel wants to merge 1 commit into
philippemnoel wants to merge 1 commit into
Conversation
dosubot
Bot
added
size:S
philippemnoel
force-pushed
the
phil/alert-templating-and-replica-secret
branch
from
a848f49 to
06554f2
Compare
philippemnoel
force-pushed
the
phil/alert-templating-and-replica-secret
branch
from
06554f2 to
a8bd427
Compare
dosubot
Bot
added
size:XS
philippemnoel
force-pushed
the
phil/alert-templating-and-replica-secret
branch
from
a8bd427 to
4f4d190
Compare
philippemnoel
force-pushed
the
phil/alert-templating-and-replica-secret
branch
2 times, most recently
from
07d9a2c to
bb8f536
Compare
…181) Signed-off-by: Philippe Noël <21990816+philippemnoel@users.noreply.github.com>
philippemnoel
force-pushed
the
phil/alert-templating-and-replica-secret
branch
from
bb8f536 to
e94cdee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I caught these while working on the @paradedb fork. Figured these changes would benefit upstream and reduce our diff:
subnametemplating in all 6 logical replication alert descriptions:{{ "{{ .subname }}" }}renders as a literal{{ .subname }}string instead of the actual subscription name. Changed to{{ .labels.subname }}which correctly references the label value from the dictsubname,lag_type, andstop_reasonlabels to the prometheus-rule template dict so alert descriptions can actually reference themcreateandvaluefields to the replicapasswordSecretconfig in values.yaml and schema, matching the pattern already used by the otherexternalClusterspassword secretsEnjoy!