feat(api): add S3 addressing style configuration - #288
Open
ChandonPierre wants to merge 1 commit into
Open
Conversation
Some S3-compatible object stores require virtual-hosted-style requests and reject path-style requests. Barman supports configuring `--addressing-style`: EnterpriseDB/barman@e81a459 `barman-cloud` supports passing this configuration in a round-about way via various `additionalCommandArgs`: https://github.com/cloudnative-pg/barman-cloud/blob/950b0f57e122e9bbfef059193801a34664cfd3ad/pkg/archiver/command.go#L51 However that requires configuring the same command argument at every command builder that calls `barman` - additionally, the current interface does not support passing additional args to `barman-cloud-backup-list`, `barman-cloud-backup-show`, `barman-cloud-backup-delete`. Rather than requiring virtual host consumers to duplicate the argument surface - add a top-level `addressingStyle` configuration that appends to command builder, so the single configuration parameter passes down to all calling instances of `barman`. Signed-off-by: Chandon Pierre <cpierre@coreweave.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some S3-compatible object stores require virtual-hosted-style requests and reject path-style requests.
Barman supports configuring
--addressing-style: EnterpriseDB/barman@e81a459barman-cloudsupports passing this configuration in a round-about way via variousadditionalCommandArgs:barman-cloud/pkg/archiver/command.go
Line 51 in 950b0f5
However that requires configuring the same command argument at every command builder that calls
barman- additionally, the current interface does not support passing additional args tobarman-cloud-backup-list,barman-cloud-backup-show,barman-cloud-backup-delete.Rather than requiring virtual host consumers to duplicate the argument surface - add a top-level
addressingStyleconfiguration that appends to command builder, so the single configuration parameter passes down to all calling instances ofbarman.