CLOS-4726: target_userspace_creator: allow erasing conflicting packages during cloudlinux-release localinstall#67
Open
prilr wants to merge 1 commit into
Conversation
…loudlinux-release localinstall The preliminary `dnf localinstall cloudlinux-release` in prepare_target_userspace runs against the source overlay, so the source rpmdb is in scope. The target release's intentional Conflicts (e.g. cloudlinux-release-8 `Conflicts: rhn-client-tools < 2.11.5`, added by CLOS-3472 for the rhn hooks support) have no upgrade candidate on the source OS, so without --allowerasing dnf cannot resolve them and target_userspace_creator crashes on CL7->CL8 for any host carrying the default el7 rhn-client-tools 2.0.2 (ZD 287724). Add --allowerasing so dnf resolves the conflict by erasing the legacy package in the throwaway overlay, matching the real upgrade transaction which already runs with allow_erasing=True. Also covers the sibling cloudlinux-ea4-release < 1-11 conflict. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The preliminary
dnf localinstall cloudlinux-releasein prepare_target_userspace runs against the source overlay, so the source rpmdb is in scope. The target release's intentional Conflicts (e.g. cloudlinux-release-8Conflicts: rhn-client-tools < 2.11.5, added by CLOS-3472 for the rhn hooks support) have no upgrade candidate on the source OS, so without --allowerasing dnf cannot resolve them and target_userspace_creator crashes on CL7->CL8 for any host carrying the default el7 rhn-client-tools 2.0.2 (ZD 287724).Add --allowerasing so dnf resolves the conflict by erasing the legacy package in the throwaway overlay, matching the real upgrade transaction which already runs with allow_erasing=True. Also covers the sibling cloudlinux-ea4-release < 1-11 conflict.