Skip to content

Upgrade node & composer packages #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabrielcld2 wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Upgrade node & composer packages #1263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7ba21c
Upgrade node packages
gabriel-detassigny Sep 2, 2026
777a490
Update composer packages
gabriel-detassigny Sep 2, 2026
8624d1a
Update packages & fix linting issues
gabriel-detassigny Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
},
"require-dev": {
"dealerdirect/phpcodesniffer-composer-installer": "^1.2.1",
"phpcompatibility/phpcompatibility-wp": "dev-master",
"phpcompatibility/php-compatibility": "dev-develop as 9.99.99",
"phpcompatibility/phpcompatibility-wp": "^2.1.8",
"phpcompatibility/php-compatibility": "^9.3.5",
"automattic/vipwpcs": "^3.0",
"wp-coding-standards/wpcs": "^3.0",
"phpstan/phpstan": "^2.0",
Expand Down Expand Up @@ -41,5 +41,6 @@
"phpunit"
]
},
"minimum-stability": "dev"
"minimum-stability": "dev",
"prefer-stable": true
}
339 changes: 185 additions & 154 deletions composer.lock
View file
Open in desktop

Large diffs are not rendered by default.

363 changes: 208 additions & 155 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion php/cache/class-cache-point.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ public function delete_meta( $check, $object_id, $meta_key, $meta_value ) {
if ( self::POST_TYPE_SLUG === get_post_type( $object_id ) ) {
$check = false;
$meta = $this->get_meta_cache( $object_id );
if ( isset( $meta[ $meta_key ] ) && $meta[ $meta_key ] === $meta_value || is_null( $meta_value ) ) {
if ( ( isset( $meta[ $meta_key ] ) && $meta[ $meta_key ] === $meta_value ) || is_null( $meta_value ) ) {
unset( $meta[ $meta_key ] );
$check = $this->set_meta_cache( $object_id, $meta );
}
Expand Down
2 changes: 1 addition & 1 deletion php/class-cron.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ public function process_schedule() {

// Default is on. So if it has not been set, default applies.
$slug = sanitize_title( $name );
if ( $this->locker->has_lock_file( $name ) || isset( $tasks[ $slug ] ) && 'off' === $tasks[ $slug ] ) {
if ( $this->locker->has_lock_file( $name ) || ( isset( $tasks[ $slug ] ) && 'off' === $tasks[ $slug ] ) ) {
continue;
}

Expand Down
2 changes: 1 addition & 1 deletion php/class-sync.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1185,7 +1185,7 @@ public function delete_cloudinary_meta( $attachment_id ) {
wp_update_attachment_metadata( $attachment_id, $meta );

// Cleanup postmeta.
$queued = get_post_meta( $attachment_id, self::META_KEYS['queued'] );
$queued = get_post_meta( $attachment_id, self::META_KEYS['queued'], true );
delete_post_meta( $attachment_id, self::META_KEYS['sync_error'] );
delete_post_meta( $attachment_id, self::META_KEYS['pending'] );
delete_post_meta( $attachment_id, self::META_KEYS['queued'] );
Expand Down
1 change: 1 addition & 0 deletions php/delivery/class-lazy-load.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ public function bypass_lazy_load( $bypass, $tag_element ) {
public function get_inline_script() {
$config = $this->get_config();

// phpcs:ignore WordPressVIPMinimum.Performance.FetchingRemoteData.FileGetContentsUnknown -- Reads a local file bundled with the plugin, not remote data.
return 'var CLDLB = ' . wp_json_encode( $config ) . ';' . file_get_contents( $this->plugin->dir_path . 'js/inline-loader.js' );
}

Expand Down
1 change: 1 addition & 0 deletions phpcs.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
<exclude-pattern>/js/</exclude-pattern>
<exclude-pattern>/node_modules/</exclude-pattern>
<exclude-pattern>/vendor/</exclude-pattern>
<exclude-pattern>/.phpstan-cache/</exclude-pattern>
<!-- Static analysis stub files intentionally mirror third-party APIs. -->
<exclude-pattern>/tests/phpstan/stubs/</exclude-pattern>
<!-- PHPUnit tests follow the WordPress core test suite conventions,
Expand Down
Loading