docs: improve a11y and usability for docs homepage - #660
Open
code-sharad wants to merge 1 commit into
Open
code-sharad wants to merge 1 commit into
code-sharad wants to merge 1 commit into
Conversation
- add semantic landmarks (header, main, section) for assistive tech - add alt text for Cloudinary App Gallery images - add visible focus-visible styles for keyboard navigation - increase CTA touch targets to 44px - honor prefers-reduced-motion - fix nested anchor in Visit App Gallery button Fixes cloudinary-community#628
|
@code-sharad is attempting to deploy a commit to the Cloudinary DevX Team on Vercel. A member of the Team first needs to authorize it. |
PaulBoye-py
requested changes
Sep 17, 2026
PaulBoye-py
left a comment
PaulBoye-py
left a comment
Collaborator
There was a problem hiding this comment.
hello @code-sharad, the alt text fixes, focus styles, touch targets, reduced-motion support, and nested anchor fix are all good improvements.
One issue: the PR adds a <header> in both _app.mdx (changelog banner) and index.mdx (hero section), resulting in two <header> landmarks on the same page. Consider changing the hero wrapper in index.mdx to <section> instead as the changelog banner <header> in _app.mdx is the more appropriate use of the landmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #628
Implemented all acceptance criteria from the issue:
<header>,<main>,<section>) for assistive tech:focus-visiblestyles for keyboard navigationprefers-reduced-motionsupport<a>inside<Button>(invalid HTML on the App Gallery CTA)Files changed:
docs/pages/index.mdxdocs/pages/_app.mdxdocs/styles/global.scssdocs/components/Button/Button.jsVerified locally with
pnpm dev— Tab focus, landmarks, and Lighthouse a11y all check out.