Skip to content

Conversation

@nuttycom
Copy link
Contributor

@nuttycom nuttycom commented Dec 15, 2024

This allows users who specify nonempty as a --no-default-features dependency can use the crate in environments where alloc is available but std is not, such as embedded device firmware.

This requires edition = 2021, which implies a change to an MSRV of 1.56, therefor , will require a semver bump for release.

@nuttycom nuttycom marked this pull request as draft December 16, 2024 16:03
@nuttycom nuttycom requested a review from FintanH December 16, 2024 16:18
@nuttycom nuttycom marked this pull request as ready for review December 16, 2024 16:18
Copy link
Collaborator

@FintanH FintanH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me 👌 @cloudhead any chance we could get this in a cut a release for @nuttycom? 🙏

`std` is now a default-enabled feature, and it is also implied by
`arbitrary`.
@FintanH
Copy link
Collaborator

FintanH commented Dec 17, 2024

@nuttycom just updated to see if the build looks fine with the clippy changes

@FintanH
Copy link
Collaborator

FintanH commented Dec 17, 2024

@nuttycom could we add these checks to the workflow:

  build:
    name: no-std build  and test
    strategy:
      matrix:
        os: ['ubuntu-latest', 'macos-latest']
    runs-on: ${{ matrix.os }}
    steps:
      - uses: actions/checkout@v2
      - name: Build
        run: cargo build --verbose --no-default-features
        env:
          RUSTFLAGS: -D warnings
      - name: Run tests
        run: cargo test --all --verbose --no-default-features

Because otherwise, I don't think our checks will ensure that no-std is working

@FintanH FintanH mentioned this pull request Dec 17, 2024
@FintanH
Copy link
Collaborator

FintanH commented Dec 17, 2024

Actually, I have it in #65 :)

@FintanH
Copy link
Collaborator

FintanH commented Dec 17, 2024

I've merged #65 so I'll close this.

I'll cut a release with a semver bump now :)

@FintanH FintanH closed this Dec 17, 2024
@FintanH FintanH mentioned this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants