Improve return type of NonEmpty::split #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FintanH
force-pushed
the
improve-split
branch
from
645cb0c to
df0381c
Compare
mx00s
suggested changes
Nov 14, 2024
mx00s
left a comment
mx00s
left a comment
There was a problem hiding this comment.
This doc comment is now stale:
/// If there is only one element then first == last.
Potential alternative:
/// If there is only one element then last is `None`.
mx00s
reviewed
Nov 14, 2024
mx00s
reviewed
Nov 14, 2024
FintanH
force-pushed
the
improve-split
branch
from
df0381c to
b4083ff
Compare
mx00s
approved these changes
Nov 15, 2024
Fixes #60[^issue-60]. As pointed out in #60, splitting a `NonEmpty` that contains a single element can be ambiguous to a `NonEmpty` equivalent to `(x, [x])`. A better representation for this return type is `(&T, &[T], Option<&T>)`. [^issue-60]: #60 Signed-off-by: Fintan Halpenny <fintan.halpenny@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett
FintanH
force-pushed
the
improve-split
branch
from
b4083ff to
ce74c21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #601.
As pointed out in #60, splitting a
NonEmptythat contains a single element can be ambiguous to aNonEmptyequivalent to(x, [x]). A better representation for this return type is(&T, &[T], Option<&T>).Footnotes
https://github.com/cloudhead/nonempty/issues/60 ↩