Skip to content

Conversation

@duanemay
Copy link
Member

Create StatsDClient as a Bean, so that it can be used in other places

  • lastCompletionTime is deprecated change to the Instant based call

Copilot AI review requested due to automatic review settings January 13, 2026 23:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the StatsdConfiguration to expose StatsDClient as a separate bean for reuse in other parts of the application, and modernizes the date/time handling by replacing deprecated API calls with the Instant-based API.

Changes:

  • Extracted StatsDClient creation into its own bean method for dependency injection
  • Updated schedulingConfigurer to use the modern lastCompletion() method instead of deprecated lastCompletionTime()
  • Refactored date manipulation to use Instant API with ChronoUnit instead of Calendar
  • Added test for StatsdConfiguration to verify bean wiring

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
StatsdConfiguration.java Extracts StatsDClient as a separate bean and modernizes date/time handling with Instant API
StatsdConfigurationTest.java Adds new test to verify Spring configuration bean wiring

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@duanemay duanemay changed the title Create StatsDClient as a Bean Expose StatsDClient as a Bean Jan 14, 2026
- fix some deprecated method calls
@github-project-automation github-project-automation bot moved this from Inbox to Pending Merge | Prioritized in Foundational Infrastructure Working Group Jan 22, 2026
@duanemay duanemay merged commit 0727ae9 into develop Jan 22, 2026
32 of 34 checks passed
@duanemay duanemay deleted the statsdclientbean branch January 22, 2026 17:12
@github-project-automation github-project-automation bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants