initial migration of bosh-s3cli patch proposal: support config from env#58
Draft
schnoddelbotz wants to merge 1 commit intocloudfoundry:mainfrom
Draft
initial migration of bosh-s3cli patch proposal: support config from env#58schnoddelbotz wants to merge 1 commit intocloudfoundry:mainfrom
schnoddelbotz wants to merge 1 commit intocloudfoundry:mainfrom
Conversation
|
|
schnoddelbotz
force-pushed
the
env-config
branch
from
ff98156 to
c2f547d
Compare
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was: cloudfoundry/bosh-s3cli#62
Originally intended to enable environment as alternative configuration source for S3 (and add a debug flag).
Still just a proposal, still just implemented for S3 ... and missing additional tests.
Does the overall approach make sense to you? If yes, I could look into corresponding adjustments for remaining providers.
Some environment variables may not even need to be digested separately by storage-cli, as the SDK picks them up -- just done to satisfy regular config validation.