Add Dav Signing Functionality#105
Draft
kathap wants to merge 1 commit into
Draft
Conversation
WebDAV needs to sign URLs against two different endpoints: one for internal consumers (Diego cells via BOSH network) and one for external consumers (CAPI downloads via gorouter). Adds public_endpoint to DAV config, SignInternal and SignPublic methods to the DAV client, and sign-internal/sign-public CLI commands via a type assertion so the cross-backend Storager interface stays unchanged.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs cloudfoundry/capi-release#650 to be in.
WebDAV needs to sign URLs against two different endpoints: one for internal consumers and one for external consumers. Adds public_endpoint to DAV config, SignInternal and SignPublic methods to the DAV client, and sign-internal/sign-public CLI commands via a type assertion so the cross-backend Storager interface stays unchanged.