fix: Per-route load balancing algorithm not reverting to platform default on removal#552
Open
hoffmaen wants to merge 3 commits intocloudfoundry:developfrom
Open
Conversation
…-route algorithm is removed When a per-route load balancing algorithm (e.g. hash-based) was removed, the pool retained the old algorithm because setPoolLoadBalancingAlgorithm ignored empty values. This fix distinguishes between "field absent" (no change) and "field explicitly empty" (reset to default) by using a *string in the NATS message struct and a sentinel value LOAD_BALANCE_DEFAULT.
cf-foundation-community-automation
bot
moved this to Inbox
in Application Runtime Platform Working Group
Co-authored-by: Tamara Boehm <tamara.boehm@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the bug where removing a per-route load balancing algorithm (e.g., via
cf update-route -r loadbalancing) left the pool using the old algorithm instead of reverting to the platform default. Fixes #551Changes
*stringforLoadBalancingAlgorithmin the NATS message struct to distinguish absent fields from explicitly empty valuesconfig.LoadBalance) inmbus/subscriber.go; only override when the NATS message contains a non-empty valueHashLookupTable,HashRoutingProperties) inEndpointPool.setPoolLoadBalancingAlgorithmwhen switching away from hash-based routingRequires [companion CC change|https://github.com/cloudfoundry/cloud_controller_ng/pull/5010] to preserve nil option values as empty strings instead of dropping them.
Backward Compatibility
Breaking Change? No