Detangle phase3#47
Merged
Merged
Conversation
ameowlia
approved these changes
Jun 18, 2026
cf-foundation-community-automation
Bot
moved this to Inbox
in Application Runtime Platform Working Group
github-project-automation
Bot
moved this from Inbox
to Pending Merge | Prioritized
in Application Runtime Platform Working Group
geofffranks
force-pushed
the
detangle-phase3
branch
from
f065a3e to
9cbc8f8
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
…ker, bin/test) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace dot gomega import with named import in cmd/locket/testrunner/runner.go. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Running with -d alone causes bash to exit immediately (no TTY/stdin), which removes the container via --rm before the test runner can attach. Adding -t allocates a pseudo-TTY so bash stays alive. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
geofffranks
force-pushed
the
detangle-phase3
branch
from
9cbc8f8 to
6828a98
Compare
github-project-automation
Bot
moved this from Pending Merge | Prioritized
to Done
in Application Runtime Platform Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds missing local testing scaffolding, fixes staticcheck issues
Backward Compatibility
Breaking Change? no