Skip to content

Add option for component preset installation#172

Merged
c0d1ngm0nk3y merged 6 commits intomainfrom
component-preset
Mar 5, 2026
Merged

Add option for component preset installation#172
c0d1ngm0nk3y merged 6 commits intomainfrom
component-preset

Conversation

@nicolasbender
Copy link
Member

No description provided.

@nicolasbender nicolasbender requested a review from a team as a code owner February 25, 2026 17:15
Copy link
Contributor

@c0d1ngm0nk3y c0d1ngm0nk3y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we get rid of all ENABLE_ options and add a workflow for the second preset?

Copy link
Contributor

@c0d1ngm0nk3y c0d1ngm0nk3y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it because it really simplifies things. Should we add a workflow to test it maybe daily?

@c0d1ngm0nk3y c0d1ngm0nk3y self-requested a review March 3, 2026 08:09
@c0d1ngm0nk3y c0d1ngm0nk3y dismissed their stale review March 3, 2026 08:10

Main concern was addressed.

@c0d1ngm0nk3y
Copy link
Contributor

c0d1ngm0nk3y
c0d1ngm0nk3y previously approved these changes Mar 4, 2026
c0d1ngm0nk3y
c0d1ngm0nk3y previously approved these changes Mar 5, 2026
@c0d1ngm0nk3y c0d1ngm0nk3y merged commit f3a3b2b into main Mar 5, 2026
2 checks passed
@c0d1ngm0nk3y c0d1ngm0nk3y deleted the component-preset branch March 5, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants