fix #1289: allowSchemeMismatch=true for tomcat server.xml#1329
Open
stephanme wants to merge 1 commit into
Open
fix #1289: allowSchemeMismatch=true for tomcat server.xml#1329stephanme wants to merge 1 commit into
stephanme wants to merge 1 commit into
Conversation
Typically, tomcat runs behind a reverse proxy (gorouter) and TLS is terminated there. This leads to a scheme mismatch between the protocol reported in http headers and what tomcat actually sees. Due to https://bz.apache.org/bugzilla/show_bug.cgi?id=70091 http2 routes don't work anymore with tomcat 10.1.55 and 11.0.22. Fix is to configure allowSchemeMismatch='true' for UpgradeProtocol in server.xml. Requires tomcat >=10.1.56 or 11.0.23.
Member
Author
|
Tested using the demo app of #1289 and my https://github.com/sap-contributions/java-buildpack fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typically, tomcat runs behind a reverse proxy (gorouter) and TLS is terminated there. This leads to a scheme mismatch between the protocol reported in http headers and what tomcat actually sees. Due to https://bz.apache.org/bugzilla/show_bug.cgi?id=70091 http2 routes don't work anymore with tomcat 10.1.55 and 11.0.22.
Fix is to configure allowSchemeMismatch='true' for UpgradeProtocol in server.xml. Requires tomcat >=10.1.56 or 11.0.23.