Skip to content

Introduce exclude cidrs list from rate-limiting feature#948

Open
Mrizwanshaik wants to merge 3 commits into
cloudfoundry:masterfrom
sap-contributions:add-nat-exclusion-list
Open

Introduce exclude cidrs list from rate-limiting feature#948
Mrizwanshaik wants to merge 3 commits into
cloudfoundry:masterfrom
sap-contributions:add-nat-exclusion-list

Conversation

@Mrizwanshaik

@Mrizwanshaik Mrizwanshaik commented Jul 10, 2026

Copy link
Copy Markdown
Contributor
  • Adds an optional ha_proxy.connections_rate_limit.exclude_cidrs property that exempts specific source ranges (e.g. internal/NAT ranges, health checkers,trusted peers) from connection-based rate limiting.

  • Excluded sources are still tracked in the st_tcp_conn_rate stick-table (so they remain visible via show table st_tcp_conn_rate), but are never rejected, regardless of the configured threshold or the runtime block setting.

@Mrizwanshaik
Mrizwanshaik force-pushed the add-nat-exclusion-list branch from 53c4f07 to cd81126 Compare July 10, 2026 11:03
@Mrizwanshaik
Mrizwanshaik marked this pull request as ready for review July 13, 2026 07:10
Comment thread spec/haproxy/templates/haproxy_config/rate_limit_spec.rb Outdated
Comment thread jobs/haproxy/templates/haproxy.config.erb Outdated
b1tamara
b1tamara previously approved these changes Jul 14, 2026

@b1tamara b1tamara left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to run CI

@github-project-automation github-project-automation Bot moved this from Inbox to Pending Merge | Prioritized in Application Runtime Platform Working Group Jul 14, 2026
@b1tamara b1tamara added the run-ci Allow this PR to be tested on Concourse label Jul 14, 2026
Comment thread jobs/haproxy/templates/haproxy.config.erb Outdated
@Mrizwanshaik
Mrizwanshaik force-pushed the add-nat-exclusion-list branch from 814a12d to bb07275 Compare July 15, 2026 14:35

@a18e a18e left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval for CI - did not review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-ci Allow this PR to be tested on Concourse

Projects

Status: Pending Merge | Prioritized

Development

Successfully merging this pull request may close these issues.

3 participants