fix: Support tcp connection rejection & rate-limiting when Proxy protocol is enabled#927
Merged
Merged
Conversation
cf-foundation-community-automation
Bot
moved this to Inbox
in Application Runtime Platform Working Group
github-project-automation
Bot
moved this from Inbox
to Pending Merge | Prioritized
in Application Runtime Platform Working Group
b1tamara
changed the title
a18e
reviewed
May 29, 2026
a18e
reviewed
May 29, 2026
a18e
approved these changes
May 29, 2026
a18e
changed the title
github-project-automation
Bot
moved this from Pending Merge | Prioritized
to Done
in Application Runtime Platform Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Haproxy connection rate limiting applies a TCP reject of the connection whenever the limit is exceeded.
When the proxy protocol is enabled, the source IP during connection initiation is the LB's IP address. The proxy protocol header is only conveyed once the session is established.
The current PR provides a fix to determine whether TCP reject of the connection or TCP reject of the session will be applied, depending on the accept proxy property.