Add CREDHUB_HOME env variable to override default home - #134
Open
ionphractal wants to merge 1 commit into
Open
Conversation
cf-foundation-community-automation
Bot
moved this to Inbox
in Foundational Infrastructure Working Group
Contributor
|
Created an internal Issue (TNZ-129716) to track this. |
hsinn0
requested changes
Aug 31, 2026
hsinn0
left a comment
hsinn0
left a comment
Contributor
There was a problem hiding this comment.
Please make sure compile & test passes in Windows.
| return home | ||
| } | ||
|
|
||
| home := os.Getenv("HOMEDRIVE") + os.Getenv("HOMEPATH") |
Contributor
There was a problem hiding this comment.
Ran this through an AI tool, and it says that this will be a compile error:
config/config_win.go:17:7: no new variables on left side of :=
For re-declaration of 'home' in the same scope.
| os.Setenv("USERPROFILE", `C:\Users\original-user`) | ||
| os.Setenv("CREDHUB_HOME", `C:\custom\credhub\home`) | ||
|
|
||
| Expect(config.ConfigDir()).To(Equal(`C:\custom\credhub\home\.credhub`)) |
Contributor
There was a problem hiding this comment.
AI analysis:
Because path.Join uses /, config.ConfigDir() returns C:\custom\credhub\home/.credhub, which will cause the test assertion to fail.
github-project-automation
Bot
moved this from Inbox
to Waiting for Changes | Open for Contribution
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like the
cfcli (CF_HOME), it is sometimes of advantage to be able to set a different home to be able to run credhub commands against different servers within one user.For example if you run cronjobs under the same user, the context (.credhub config) would be diluted/overwritten by a later running script, causing unwanted results.
This PR adds CREDHUB_HOME for both linux and windows versions.